style: clang-tidy auto fixes (#2013)

Fixes #2012. Please review and commit clang-tidy fixes.

Co-authored-by: godexsoft <385326+godexsoft@users.noreply.github.com>

Author: github-actions[bot]

src/util/BlockingCache.hpp

@@ -201,7 +201,7 @@ class BlockingCache {
         boost::system::error_code errorCode;
 
         std::optional<std::expected<ValueType, ErrorType>> result;
-        boost::signals2::scoped_connection slot =
+        boost::signals2::scoped_connection const slot =
             updateFinished_.connect([yield, &timer, &result](std::expected<ValueType, ErrorType> value) {
                 boost::asio::spawn(yield, [&timer, &result, value = std::move(value)](auto&&) {
                     result = std::move(value);

tests/unit/rpc/RPCHelpersTests.cpp

@@ -1219,7 +1219,7 @@ TEST_P(RPCHelpersLogDurationTest, LogDuration)
     EXPECT_NE(output.find(tagStr), std::string::npos);
 
     if (GetParam().expectDuration) {
-        std::string durationStr = std::to_string(GetParam().duration.count()) + " milliseconds";
+        std::string const durationStr = std::to_string(GetParam().duration.count()) + " milliseconds";
         EXPECT_NE(output.find(durationStr), std::string::npos);
     }
 

tests/unit/util/BlockingCacheTests.cpp

@@ -21,8 +21,6 @@
 #include "util/BlockingCache.hpp"
 #include "util/NameGenerator.hpp"
 
-#include <boost/asio/error.hpp>
-#include <boost/asio/post.hpp>
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
@@ -33,7 +31,6 @@ using testing::Return;
 using testing::StrictMock;
 
 #include <boost/asio/spawn.hpp>
-#include <boost/asio/steady_timer.hpp>
 
 #include <chrono>
 #include <expected>

tests/unit/util/ResponseExpirationCacheTests.cpp

@@ -50,7 +50,7 @@ struct ResponseExpirationCacheTest : SyncAsioContextTest {
 
 TEST_F(ResponseExpirationCacheTest, ShouldCacheDeterminesIfCommandIsCacheable)
 {
-    std::unordered_set<std::string> cmds = {cmd, "account_info"};
+    std::unordered_set<std::string> const cmds = {cmd, "account_info"};
     ResponseExpirationCache cache{std::chrono::seconds(10), cmds};
 
     for (auto const& c : cmds) {
@@ -259,7 +259,7 @@ TEST_F(ResponseExpirationCacheTest, InvalidateForcesRefresh)
     ResponseExpirationCache cache{std::chrono::seconds(10), {cmd}};
 
     runSpawn([&](boost::asio::yield_context yield) {
-        boost::json::object oldObject = {{"some key", "old value"}};
+        boost::json::object const oldObject = {{"some key", "old value"}};
         EXPECT_CALL(mockUpdater, Call)
             .WillOnce(Return(ResponseExpirationCache::EntryData{
                 .lastUpdated = std::chrono::steady_clock::now(),