Review fixes

Author: mathbunnyru

src/rpc/handlers/VaultList.cpp

@@ -52,8 +52,8 @@
 
 namespace rpc {
 
-VaultListHandler::VaultListHandler(std::shared_ptr<BackendInterface> const& sharedPtrBackend)
-    : sharedPtrBackend_(sharedPtrBackend)
+VaultListHandler::VaultListHandler(std::shared_ptr<BackendInterface> sharedPtrBackend)
+    : sharedPtrBackend_(std::move(sharedPtrBackend))
 {
 }
 
@@ -67,7 +67,7 @@ VaultListHandler::process(VaultListHandler::Input const& input, Context const& c
         *sharedPtrBackend_, ctx.yield, input.ledgerHash, input.ledgerIndex, range->maxSequence
     );
 
-    if (!expectedLgrInfo.has_value())
+    if (not expectedLgrInfo.has_value())
         return Error{expectedLgrInfo.error()};
 
     auto const& lgrInfo = *expectedLgrInfo;

src/rpc/handlers/VaultList.hpp

@@ -85,7 +85,7 @@ class VaultListHandler {
      *
      * @param sharedPtrBackend The backend to use
      */
-    VaultListHandler(std::shared_ptr<BackendInterface> const& sharedPtrBackend);
+    VaultListHandler(std::shared_ptr<BackendInterface> sharedPtrBackend);
 
     /**
      * @brief Returns the API specification for the command