chore: Enable debug symbols

Author: mathbunnyru

cmake/ClioPackage.cmake

@@ -2,7 +2,6 @@ include("${CMAKE_CURRENT_LIST_DIR}/ClioVersion.cmake")
 
 set(CPACK_PACKAGING_INSTALL_PREFIX "/opt/clio")
 set(CPACK_PACKAGE_VERSION "${CLIO_VERSION}")
-set(CPACK_STRIP_FILES TRUE)
 
 include(pkg/deb)
 include(CPack)

cmake/Settings.cmake

@@ -79,3 +79,6 @@ if (time_trace)
 endif ()
 
 target_compile_options(clio_options INTERFACE ${COMPILER_FLAGS})
+
+# Add debug symbols for all builds, including Release. This is needed to get useful stack traces in production.
+target_compile_options(clio_options INTERFACE -g)

tests/integration/CMakeLists.txt

@@ -15,9 +15,6 @@ target_sources(clio_integration_tests
                        TestGlobals.cpp
                        Main.cpp)
 
-# Fix for dwarf5 bug on ci. IS STILL NEEDED???
-target_compile_options(clio_options INTERFACE -gdwarf-4)
-
 target_include_directories(clio_integration_tests PRIVATE .)
 target_link_libraries(clio_integration_tests PUBLIC clio_testing_common PRIVATE Boost::program_options)
 set_target_properties(clio_integration_tests PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR})

tests/unit/CMakeLists.txt

@@ -222,9 +222,6 @@ target_sources(clio_tests
 # See https://github.com/google/googletest/issues/3475
 gtest_discover_tests(clio_tests DISCOVERY_TIMEOUT 90)
 
-# Fix for dwarf5 bug on ci
-target_compile_options(clio_options INTERFACE -gdwarf-4)
-
 target_include_directories(clio_tests PRIVATE .)
 target_link_libraries(clio_tests PUBLIC clio_testing_common PRIVATE spdlog::spdlog)
 set_target_properties(clio_tests PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR})