Merge branch 'develop' into no_conan_options

Author: mathbunnyru

.github/workflows/upload_coverage_report.yml

@@ -25,7 +25,7 @@ jobs:
 
       - name: Upload coverage report
         if: ${{ hashFiles('build/coverage_report.xml') != '' }}
-        uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
+        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
         with:
           files: build/coverage_report.xml
           fail_ci_if_error: true

tests/common/util/TestObject.cpp

@@ -1493,7 +1493,7 @@ createMPTIssuanceCreateTx(std::string_view accountId, uint32_t fee, uint32_t seq
 data::TransactionAndMetadata
 createMPTIssuanceCreateTxWithMetadata(std::string_view accountId, uint32_t fee, uint32_t seq)
 {
-    ripple::STObject tx = createMPTIssuanceCreateTx(accountId, fee, seq);
+    ripple::STObject const tx = createMPTIssuanceCreateTx(accountId, fee, seq);
 
     ripple::STObject metaObj(ripple::sfTransactionMetaData);
     metaObj.setFieldU8(ripple::sfTransactionResult, ripple::tesSUCCESS);
@@ -1509,7 +1509,7 @@ createMPTIssuanceCreateTxWithMetadata(std::string_view accountId, uint32_t fee,
     newFields.setFieldU64(ripple::sfOutstandingAmount, 0);
     newFields.setFieldH256(ripple::sfPreviousTxnID, ripple::uint256{});
     newFields.setFieldU32(ripple::sfPreviousTxnLgrSeq, 0);
-    std::string_view metadata = "test-meta";
+    std::string_view const metadata = "test-meta";
     ripple::Slice const sliceMetadata(metadata.data(), metadata.size());
     newFields.setFieldVL(ripple::sfMPTokenMetadata, sliceMetadata);