From 10c294f0de283b6a153d716ecea9b68ba8b8c545 Mon Sep 17 00:00:00 2001 From: Bart Date: Thu, 18 Dec 2025 09:49:01 -0500 Subject: [PATCH 1/2] ci: Assign inputs to environment variables before using them in run statements --- .github/actions/conan/action.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/actions/conan/action.yml b/.github/actions/conan/action.yml index 52ed03dd70..3376a9dd16 100644 --- a/.github/actions/conan/action.yml +++ b/.github/actions/conan/action.yml @@ -27,19 +27,23 @@ runs: steps: - name: Create build directory shell: bash - run: mkdir -p "${{ inputs.build_dir }}" + env: + BUILD_DIR: "${{ inputs.build_dir }}" + run: mkdir -p "${BUILD_DIR}" - name: Run conan shell: bash env: - CONAN_BUILD_OPTION: "${{ inputs.force_conan_source_build == 'true' && '*' || 'missing' }}" BUILD_BENCHMARK: "${{ inputs.build_benchmark == 'true' && 'True' || 'False' }}" + BUILD_TYPE: "${{ inputs.build_type }}" + CONAN_BUILD_OPTION: "${{ inputs.force_conan_source_build == 'true' && '*' || 'missing' }}" + CONAN_PROFILE: "${{ inputs.conan_profile }}" run: | conan \ install . \ -of build \ -b "$CONAN_BUILD_OPTION" \ - -s "build_type=${{ inputs.build_type }}" \ + -s "build_type=${BUILD_TYPE}" \ -o "&:tests=True" \ -o "&:benchmark=${BUILD_BENCHMARK}" \ - --profile:all "${{ inputs.conan_profile }}" + --profile:all "${CONAN_PROFILE}" From 303ecd83745daf4b7eb8afd1907d28c095e24790 Mon Sep 17 00:00:00 2001 From: Bart Date: Thu, 18 Dec 2025 10:01:52 -0500 Subject: [PATCH 2/2] Remove creation of build directory --- .github/actions/conan/action.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/actions/conan/action.yml b/.github/actions/conan/action.yml index feaec61f53..897c3e5489 100644 --- a/.github/actions/conan/action.yml +++ b/.github/actions/conan/action.yml @@ -21,12 +21,6 @@ inputs: runs: using: composite steps: - - name: Create build directory - shell: bash - env: - BUILD_DIR: "${{ inputs.build_dir }}" - run: mkdir -p "${BUILD_DIR}" - - name: Run conan shell: bash env: