Skip to content

Commit 263dd4e

Browse files
authored
Remove unnecessary boost::system requirement for NuDB (#34)
The NuDB recipe will not build when using Boost 1.89+ as `boost::system` is no longer there, and has actually not even been needed since Boost 1.69. See also conan-io#28808. This change, therefore, removes that requirement from NuDB's `conanfile.py`, and bumps the Boost version too. Local testing with `xrpld` shows that the compilation succeeds.
1 parent 8333082 commit 263dd4e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/export.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ jobs:
3939
conan export ed25519/all --version=2015.03
4040
conan export grpc/all --version=1.72.0
4141
conan export m4/all --version=1.4.19
42+
conan export nudb/all --version=2.0.9
4243
conan export openssl/3.x.x --version=3.5.4
4344
conan export secp256k1/all --version=0.7.0
4445
conan export snappy/all --version=1.1.10

recipes/nudb/all/conanfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def layout(self):
2828
basic_layout(self, src_folder="src")
2929

3030
def requirements(self):
31-
self.requires("boost/1.83.0")
31+
self.requires("boost/1.90.0")
3232

3333
def package_id(self):
3434
self.info.clear()
@@ -61,7 +61,7 @@ def package_info(self):
6161
self.cpp_info.components["core"].set_property("cmake_target_name", "nudb")
6262
self.cpp_info.components["core"].names["cmake_find_package"] = "nudb"
6363
self.cpp_info.components["core"].names["cmake_find_package_multi"] = "nudb"
64-
self.cpp_info.components["core"].requires = ["boost::thread", "boost::system"]
64+
self.cpp_info.components["core"].requires = ["boost::thread"]
6565

6666
# TODO: to remove in conan v2 once cmake_find_package_* generators removed
6767
self.cpp_info.names["cmake_find_package"] = "NuDB"

0 commit comments

Comments
 (0)