Review feedback

Author: bthomee

recipes/secp256k1/all/conandata.yml

@@ -1,4 +1,4 @@
 sources:
   "0.7.0":
-    sha256: 073d19064f3600014750d6949b31a0c957aa7b98920fb4aaa495be07e8e7cd00
     url: https://github.com/bitcoin-core/secp256k1/archive/refs/tags/v0.7.0.tar.gz
+    sha256: 073d19064f3600014750d6949b31a0c957aa7b98920fb4aaa495be07e8e7cd00

recipes/secp256k1/all/conanfile.py

@@ -26,17 +26,14 @@ def source(self):
     def generate(self):
         tc = CMakeToolchain(self)
         # Disable all tests and benchmarks.
-        tc.variables["SECP256K1_INSTALL"] = 1
-        tc.variables["SECP256K1_BUILD_BENCHMARK"] = 0
-        tc.variables["SECP256K1_BUILD_TESTS"] = 0
-        tc.variables["SECP256K1_BUILD_EXHAUSTIVE_TESTS"] = 0
-        tc.variables["SECP256K1_BUILD_CTIME_TESTS"] = 0
-        tc.variables["SECP256K1_BUILD_EXAMPLES"] = 0
+        tc.variables["SECP256K1_INSTALL"] = True
+        tc.variables["SECP256K1_BUILD_BENCHMARK"] = False
+        tc.variables["SECP256K1_BUILD_TESTS"] = False
+        tc.variables["SECP256K1_BUILD_EXHAUSTIVE_TESTS"] = False
+        tc.variables["SECP256K1_BUILD_CTIME_TESTS"] = False
+        tc.variables["SECP256K1_BUILD_EXAMPLES"] = False
         tc.generate()
 
-        deps = CMakeDeps(self)
-        deps.generate()
-
     def build(self):
         cmake = CMake(self)
         cmake.verbose = True
@@ -52,6 +49,3 @@ def package_info(self):
         self.cpp_info.libs = ["secp256k1"]
         self.cpp_info.names["cmake_find_package"] = "secp256k1"
         self.cpp_info.names["cmake_find_package_multi"] = "secp256k1"
-
-    def package_id(self):
-        self.info.clear()