treat unimpaired loan

Tapanito · Tapanito · commit 27200ab680ce · 2025-12-03T15:05:02.000+01:00
diff --git a/src/xrpld/app/tx/detail/LoanPay.cpp b/src/xrpld/app/tx/detail/LoanPay.cpp
@@ -305,7 +305,13 @@ LoanPay::doApply()
     // change will be discarded.
     if (loanSle->isFlag(lsfLoanImpaired))
     {
-        LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);
+        if (auto const ret =
+                LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);
+            ret != tesSUCCESS)
+        {
+            JLOG(j_.fatal()) << "Failed to unimpair loan before payment.";
+            return ret;  // LCOV_EXCL_LINE
+        }
     }
 
     LoanPaymentType const paymentType = [&tx]() {

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,13 @@ LoanPay::doApply()`
`305`	`305`	`// change will be discarded.`
`306`	`306`	`if (loanSle->isFlag(lsfLoanImpaired))`
`307`	`307`	`{`
`308`		`- LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);`
	`308`	`+ if (auto const ret =`
	`309`	`+ LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);`
	`310`	`+ ret != tesSUCCESS)`
	`311`	`+ {`
	`312`	`+ JLOG(j_.fatal()) << "Failed to unimpair loan before payment.";`
	`313`	`+ return ret; // LCOV_EXCL_LINE`
	`314`	`+ }`
`309`	`315`	`}`
`310`	`316`
`311`	`317`	`LoanPaymentType const paymentType = [&tx]() {`