Skip to content

Commit 335a1ac

Browse files
committed
improves LoanManage error code for dust amounts
1 parent c89ef67 commit 335a1ac

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/xrpld/app/tx/detail/LoanManage.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,11 +223,11 @@ LoanManage::defaultLoan(
223223
}
224224
if (*vaultAvailableProxy > *vaultTotalProxy)
225225
{
226-
JLOG(j.warn()) << "Vault assets available must not be greater "
227-
"than assets outstanding. Available: "
228-
<< *vaultAvailableProxy
229-
<< ", Total: " << *vaultTotalProxy;
230-
return tecLIMIT_EXCEEDED;
226+
JLOG(j_.fatal())
227+
<< "Vault assets available must not be greater "
228+
"than assets outstanding. Available: "
229+
<< *vaultAvailableProxy << ", Total: " << *vaultTotalProxy;
230+
return tecINTERNAL; // LCOV_EXCL_LINE
231231
}
232232

233233
// The loss has been realized

src/xrpld/app/tx/detail/LoanPay.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -454,9 +454,11 @@ LoanPay::doApply()
454454

455455
if (*assetsAvailableProxy > *assetsTotalProxy)
456456
{
457-
// LCOV_EXCL_START
458-
return tecINTERNAL;
459-
// LCOV_EXCL_STOP
457+
JLOG(j_.fatal())
458+
<< "Vault assets available must not be greater "
459+
"than assets outstanding. Available: "
460+
<< *assetsAvailableProxy << ", Total: " << *assetsTotalProxy;
461+
return tecINTERNAL; // LCOV_EXCL_LINE
460462
}
461463
}
462464

0 commit comments

Comments
 (0)