Skip to content

Commit 359a94b

Browse files
committed
add account id to batch serialization
1 parent 5e39c1d commit 359a94b

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

src/libxrpl/protocol/STTx.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,7 @@ STTx::checkBatchSingleSign(STObject const& batchSigner) const
417417
{
418418
Serializer msg;
419419
serializeBatch(msg, getFlags(), getBatchTransactionIDs());
420+
finishMultiSigningData(batchSigner.getAccountID(sfAccount), msg);
420421
return singleSignHelper(batchSigner, msg.slice());
421422
}
422423

src/test/app/Batch_test.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -550,6 +550,7 @@ class Batch_test : public beast::unit_test::suite
550550

551551
Serializer msg;
552552
serializeBatch(msg, tfAllOrNothing, jt.stx->getBatchTransactionIDs());
553+
finishMultiSigningData(bob.id(), msg);
553554
auto const sig = xrpl::sign(bob.pk(), bob.sk(), msg.slice());
554555
jt.jv[sfBatchSigners.jsonName][0u][sfBatchSigner.jsonName][sfAccount.jsonName] =
555556
bob.human();

src/test/jtx/impl/batch.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ sig::operator()(Env& env, JTx& jt) const
7474

7575
Serializer msg;
7676
serializeBatch(msg, stx.getFlags(), stx.getBatchTransactionIDs());
77+
finishMultiSigningData(e.acct.id(), msg);
7778
auto const sig = xrpl::sign(*publicKeyType(e.sig.pk().slice()), e.sig.sk(), msg.slice());
7879
jo[sfTxnSignature.getJsonName()] = strHex(Slice{sig.data(), sig.size()});
7980
}

0 commit comments

Comments
 (0)