Impose a local limit on path lengths

Author: JoelKatz

src/ripple_app/transactors/Payment.cpp

@@ -212,9 +212,14 @@ TER PaymentTransactor::doApply ()
         try
         {
             bool const openLedger = is_bit_set (mParams, tapOPEN_LEDGER);
-            bool const tooManyPaths = spsPaths.size () > MaxPathSize;
 
-            terResult = openLedger && tooManyPaths
+            bool pathTooBig = spsPaths.size () > MaxPathSize;
+
+            for (auto const& path : spsPaths)
+                if (path.size () > MaxPathLength)
+                    pathTooBig = true;
+
+            terResult = openLedger && pathTooBig
                         ? telBAD_PATH_COUNT // Too many paths for proposed ledger.
                         : RippleCalc::rippleCalc (
                               mEngine->view (),

src/ripple_app/transactors/Payment.h

@@ -37,6 +37,9 @@ class PaymentTransactor
     /* The largest number of paths we allow */
     static std::size_t const MaxPathSize = 6;
 
+    /* The longest path we allow */
+    static std::size_t const MaxPathLength = 8;
+
 public:
     PaymentTransactor (
         SerializedTransaction const& txn,