adds nodiscard

Author: Tapanito

src/xrpld/app/tx/detail/LoanManage.cpp

@@ -338,7 +338,7 @@ LoanManage::impairLoan(
     return tesSUCCESS;
 }
 
-TER
+[[nodiscard]] TER
 LoanManage::unimpairLoan(
     ApplyView& view,
     SLE::ref loanSle,

src/xrpld/app/tx/detail/LoanManage.h

@@ -49,7 +49,7 @@ class LoanManage : public Transactor
 
     /** Helper function that might be needed by other transactors
      */
-    static TER
+    [[nodiscard]] static TER
     unimpairLoan(
         ApplyView& view,
         SLE::ref loanSle,

src/xrpld/app/tx/detail/LoanPay.cpp

@@ -306,7 +306,7 @@ LoanPay::doApply()
     if (loanSle->isFlag(lsfLoanImpaired))
     {
         if (auto const ret =
-                LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);
+                LoanManage::unimpairLoan(view, loanSle, vaultSle, asset, j_);
             ret != tesSUCCESS)
         {
             JLOG(j_.fatal()) << "Failed to unimpair loan before payment.";