Skip to content

Commit 9fe50c9

Browse files
first draft
refactor: Update Conan dependencies: protobuf and grpc (#5589) This PR updates protobuf and grpc to their latest versions. The latest protobuf version no longer requires patches, so we can use it directly from the official Conan Center Index, while the latest grpc still needed a patch, which was added to our own Conan Center Index fork in XRPLF/conan-center-index#8. cleanup docs: Infer version of Conan dependency to export (#6112) This change updates a script in the documentation to automatically infer the version of a patched Conan dependency from the conan.lock file. chore: Use updated secp256k1 recipe (#6118) This change updates the secp256k1 recipe that defines the SECP256K1_STATIC, so it no longer needs to be defined in the code here. Running the Conan update script also updated two other recipes in the lock file. chore: Clean up .gitignore and .gitattributes (#6001) The .gitignore and .gitattributes files contain references to files and directories that the current build no longer produces, so this change removes obsolete entries in these files, and does some general reorganizing of the remaining entries. chore: Fix docs readme and cmake (#6122) This change removes the unused `with_docs` option and fixes the README instructions on how to build the `docs` target. removed amendment changes added limit to reply size Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> minor clean-up Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> refactor: clean up `RPCHelpers` (#5684) This PR cleans up `RPCHelpers.h` and `RPCHelpers.cpp`. It splits out all the fetch-ledger functions to a new set of files, `RPCLedgerHelpers.h`/`RPCLedgerHelpers.cpp`, and moves the general-API functions to `ApiVersion.h`. There is no functionality change. refactor: rename `LedgerInfo` to `LedgerHeader` (#6136) This PR renames `LedgerInfo` to `LedgerHeader`. Namely, `LedgerInfo` was already an alias for `LedgerHeader`, and the comments next to the alias suggested that it would make sense to rename it, since that makes it clearer what it is. refactor: rename info() to header() (#6138) This change renames all the `info()` functions to `header()`, since they return `LedgerHeader` structs. It also renames the underlying variables from `info_` to `header_`. refactor: Rename `rippled` binary to `xrpld` (#5983) Per [XLS-0095](https://xls.xrpl.org/xls/XLS-0095-rename-rippled-to-xrpld.html), we are taking steps to rename ripple(d) to xrpl(d). This change modifies the binary name from `rippled` to `xrpld`, and creates a symlink named `rippled` that points to the `xrpld` binary. Note that #5975 renamed any references to `rippled` in the CMake files and their contents, but explicitly maintained the `rippled` binary name by adding an exception. This change now undoes this exception and adds an explicit symlink instead. subscription test was failing, so trying with longer timeout, Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Update src/xrpld/overlay/detail/PeerImp.cpp update comparison operator. Co-authored-by: Ed Hennis <ed@ripple.com> Update src/xrpld/overlay/detail/PeerImp.cpp combine strings Co-authored-by: Ed Hennis <ed@ripple.com> refactor: Move JobQueue and related classes into xrpl.core module (#6121) refactor: Rename `ripple` namespace to `xrpl` (#5982) This change renames all occurrences of `namespace ripple` and `ripple::` to `namespace xrpl` and `xrpl::`, respectively, as well as the names of test suites. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts. chore: Fix some typos in comments (#6082) ci: Update shared actions (#6147) The latest update to `cleanup-workspace`, `get-nproc`, and `prepare-runner` moved the action to the repository root directory, and also includes some ccache changes. In response, this change updates the various shared actions to the latest commit hash. refactor: remove `Json::Object` and related files/classes (#5894) `Json::Object` and related objects are not used at all, so this change removes `include/xrpl/json/Object.h` and all downstream files. There are a number of minor downstream changes as well. Full list of deleted classes and functions: * `Json::Collections` * `Json::Object` * `Json::Array` * `Json::WriterObject` * `Json::setArray` * `Json::addObject` * `Json::appendArray` * `Json::appendObject` The last helper function, `copyFrom`, seemed a bit more complex and was actually used in a few places, so it was moved to `LedgerToJson.h` instead of deleting it. Set version to 3.2.0-b0 (#6153) ci: Remove superfluous build directory creation (#6159) This change modifies the build directory structure from `build/build/xxx` or `.build/build/xxx` to just `build/xxx`. Namely, the `conanfile.py` has the CMake generators build directory hardcoded to `build/generators`. We may as well leverage the top-level build directory without introducing another layer of directory nesting. fix: Remove cryptographic libs from libxrpl Conan package (#6163) * fix: rm crypto libs and fix protobuf path * update/rm comments chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (#6166) See pre-commit/pre-commit-hooks#1229 for more details. Revert "chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (#6166)" (#6167) This reverts commit 0f23ad8. refactor: Rename `rippled.cfg` to `xrpld.cfg` (#6098) This change renames all occurrences of `rippled.cfg` to `xrpld.cfg`. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts. For the time being it maintains support for `rippled.cfg` as config file, if `xrpld.cfg` does not exist. test: add more tests for `ledger_entry` RPC (#5858) This change adds some basic tests for all the `ledger_entry` helper functions, so each ledger entry type is covered. There are further some minor refactors in `parseAMM` to provide better error messages. Finally, to improve readability, alphabetization was applied in the helper functions. ci: Use ccache to cache build objects for speeding up building (#6104) Right now, each pipeline invocation builds the source code from scratch. Although compiled Conan dependencies are cached in a remote server, the source build objects are not. We are able to further speed up our builds by leveraging `ccache`. This change enables caching of build objects using `ccache` on Linux, macOS, and Windows. ci: Move variable into right place (#6179) This change moves the `enable_ccache` variable in the `on-trigger.yml` file to the correct location. refactor: Fix typos in comments, configure cspell (#6164) This change sets up a `cspell `configuration and fixes lots of typos in comments. There are no other code changes. refactor: Fix spelling issues in private/local variables and functions (#6182) This change fixes several typos in private/local variables and private functions. There is no functionality change. refactor: Fix spelling issues in all variables/functions (#6184) This change fixes many typos in comments, variables, and public functions. There is no functionality change. refactor: Remove unused credentials signature hash prefix (#6186) This change removes the unused credentials signature hash prefix from `HashPrefix.h`. fix: Reorder Batch Preflight Errors (#6176) This change fixes #6058. refactor: Fix typos, enable cspell pre-commit (#5719) This change fixes the last of the spelling issues, and enables the pre-commit (and CI) check for spelling. There are no functionality changes, but it does rename some enum values. ci: Use updated prepare-runner in actions and worfklows (#6188) This change updates the XRPLF pre-commit workflow and prepare-runner action to their latest versions. For naming consistency the prepare-runner action changed the disable_ccache variable into enable_ccache, which matches our naming. docs: Fix minor spelling issues in comments (#6194) fix: Truncate thread name to 15 chars on Linux (#5758) This change: * Truncates thread names if more than 15 chars with `snprintf`. * Adds warnings for truncated thread names if `-DTRUNCATED_THREAD_NAME_LOGS=ON`. * Add a static assert for string literals to stop compiling if > 15 chars. * Shortens `Resource::Manager` to `Resource::Mngr` to fix the static assert failure. * Updates `CurrentThreadName_test` unit test specifically for Linux to verify truncation. VaultClawback: Burn shares of an empty vault (#6120) - Adds a mechanism for the vault owner to burn user shares when the vault is stuck. If the Vault has 0 AssetsAvailable and Total, the owner may submit a VaultClawback to reclaim the worthless fees, and thus allow the Vault to be deleted. The Amount must be left off (unless the owner is the asset issuer), specified as 0 Shares, or specified as the number of Shares held. chore: Change `/Zi` to `/Z7` for ccache, remove debug symbols in CI (#6198) As the `/Zi` compiler flag is unsupported by ccache, this change switches it to `/Z7` instead. For CI runs all debug info is omitted. fix: Inner batch transactions never have valid signatures (#6069) - Introduces amendment `fixBatchInnerSigs` - Update Batch unit tests - Fix all the Env instantiations to _use_ the "features" parameter. - testInnerSubmitRPC runs with Batch enabled and disabled. - Add a test to testInnerSubmitRPC for a correctly signed tx incorrectly using the tfInnerBatchTxn flag. - Generalize the submitAndValidate lambda in testInnerSubmitRPC. - With the fix amendment, a transaction never reaches the transaction engine (Transactor and derived classes.) - Test submitting a pseudo-transaction. Stopped before reaching the transaction engine, but with different errors. - The tests verify that without the amendment, a transaction with tfInnerBatchTxn is immediately rejected. Without the amendment, things are safe. The amendment just makes things safer and more future-proof. chore: Pin pre-commit hooks to commit hashes (#6205) This change updates and pins the Black and CSpell pre-commit hooks. refactor: Remove unnecessary version number and options in cmake find_package (#6169) This change removes unnecessary version numbers in the OpenSSL and Boost `find_package` CMake statements. An unnecessary OpenSSL definition is removed, while Conan options for SSL are updated to disable insecure ciphers. Moreover, the statements are now ordered alphabetically and more logically. ci: Update actions/images to use cmake 4.2.1 and conan 2.24.0 (#6209) fix: Update Conan lock file with changed OpenSSL recipe (#6211) This change updates the `conan.lock` file with a changed OpenSSL recipe that contains a fix regarding options passed to the compiler Improve and fix bugs in Lending Protocol (#6102) - Spec: XLS-66 Fix overpayment asserts (#6084) MPTTester::operator() parameter should be std::int64_t - Originally defined as uint64_t, but the testIssuerLoan() test called it with a negative number, causing an overflow to a very large number that in some circumstances could be silently cast back to an int64_t, but might not be. I believe this is UB, and we don't want to rely on that. Review feedback from @Tapanito: overpayment value change - In overpayment results, the management fee was being calculated twice: once as part of the value change, and as part of the fees paid. Exclude it from the value change. Fix Overpayment Calculation (#6087) - Adds additional unit tests to cover math calculations. - Removes unused methods. Review feedback from @shawnxie999: even more rounding - Round the initial total value computation upward, unless there is 0-interest. - Rename getVaultScale to getAssetsTotalScale, and convert one incorrect computation to use it. - Use adjustImpreciseNumber for LossUnrealized. - Add some logging to computeLoanProperties. Fix LoanBrokerSet debtMaximum limits (#6116) Fix some minor bugs in Lending Protocol (#6101) - add nodiscard to unimpairLoan, and check result in LoanPay - add a check to verify that issuer exists - improve LoanManage error code for dust amounts Check permissions in LoanSet and LoanPay (#6108) Disallow pseudo accounts to be Destination for LoanBrokerCoverWithdraw (#6106) Ensure vault asset cap is not exceeded (#6124) Fix Overpayment ValueChange calculation in Lending Protocol (#6114) - Adds loan state to LoanProperties. - Cleans up computeLoanProperties. - Fixes missing management fee from overpayment. fix: Enable LP Deposits when the broker is the asset issuer (#6119) * Replace accountHolds with accountSpendable when checking for account funds in VaultDeposit and LoanBrokerCoverDeposit Add a few minor changes (#6158) - Updates or fixes a couple of things I noticed while reviewing changes to the spec. - Rename sfPreviousPaymentDate to sfPreviousPaymentDueDate. - Make the vault asset cap check added in #6124 a little more robust: 1. Check in preflight if the vault is _already_ over the limit. 2. Prevent overflow when checking with the loan value. (Subtract instead of adding, in case the values are near maxint. Both return the same result. Also add a unit test so each case is covered. Add minimum grace period validation (#6133) Fix bugs: frozen pseudo-account, and FLC cutoff (#6170) refactor: Rename raw state to theoretical state (#6187) Check if a withdrawal amount exceeds any applicable receiving limit. (#6117) Fix overpayment result calculation (#6195) Address review feedback from Lending Protocol re-review (#6161) --------- Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com> Co-authored-by: Bronek Kozicki <brok@incorrekt.com> Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com> Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com> Co-authored-by: Jingchen <a1q123456@users.noreply.github.com> Expand Number to support the full integer range (#6025) - Refactor Number internals away from int64 to uint64 & a sign flag - ctors and accessors use `rep`. Very few things expose `internalrep`. - An exception is "unchecked" and the new "normalized", which explicitly take an internalrep. But with those special control flags, it's easier to distinguish and control when they are used. - For now, skip the larger mantissas in AMM transactions and tests - Remove trailing zeros from scientific notation Number strings - Update tests. This has the happy side effect of making some of the string representations _more_ consistent between the small and large mantissa ranges. - Add semi-automatic rounding of STNumbers based on Asset types - Create a new SField metadata enum, sMD_NeedsAsset, which indicates the field should be associated with an Asset so it can be rounded. - Add a new STTakesAsset intermediate class to handle the Asset association to a derived ST class. Currently only used in STNumber, but could be used by other types in the future. - Add "associateAsset" which takes an SLE and an Asset, finds the sMD_NeedsAsset fields, and associates the Asset to them. In the case of STNumber, that both stores the Asset, and rounds the value immediately. - Transactors only need to add a call to associateAsset _after_ all of the STNumbers have been set. Unfortunately, the inner workings of STObject do not do the association correctly with uninitialized fields. - When serializing an STNumber that has an Asset, round it before serializing. - Add an override of roundToAsset, which rounds a Number value in place to an Asset, but without any additional scale. - Update and fix a bunch of Loan-related tests to accommodate the expanded Number class. --------- Co-authored-by: Vito <5780819+Tapanito@users.noreply.github.com> Change LendingProtocol feature and dependencies to supported (#6146) minor code review changes Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> test: Replace `failed` string in Vault test case (#6214) The word `failed` in the test case makes it hard to search through the test logs when an actual test failure occurs, so this change renames the word to just `fail` instead. test: Suppress "parse failed" message in Batch tests (#6207) test: Use gtest instead of doctest (#6216) This change switches over the doctest framework to the gtest framework. ci: Add sanitizers to CI builds (#5996) This change adds support for sanitizer build options in CI builds workflow. Currently `asan+ubsan` is enabled, while `tsan+ubsan` is left disabled as more changes are required. added unit test Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> updated levelization Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Improve ledger_entry lookups for fee, amendments, NUNL, and hashes (#5644) These "fixed location" objects can be found in multiple ways: 1. The lookup parameters use the same format as other ledger objects, but the only valid value is true or the valid index of the object: - Amendments: "amendments" : true - FeeSettings: "fee" : true - NegativeUNL: "nunl" : true - LedgerHashes: "hashes" : true (For the "short" list. See below.) 2. With RPC API >= 3, using special case values to "index", such as "index" : "amendments". Uses the same names as above. Note that for "hashes", this option will only return the recent ledger hashes / "short" skip list. 3. LedgerHashes has two types: "short", which stores recent ledger hashes, and "long", which stores the flag ledger hashes for a particular ledger range. - To find a "long" LedgerHashes object, request '"hashes" : <ledger sequence>'. <ledger sequence> must be a number that evaluates to an unsigned integer. - To find the "short" LedgerHashes object, request "hashes": true as with the other fixed objects. The following queries are all functionally equivalent: - "amendments" : true - "index" : "amendments" (API >=3 only) - "amendments" : "7DB0788C020F02780A673DC74757F23823FA3014C1866E72CC4CD8B226CD6EF4" - "index" : "7DB0788C020F02780A673DC74757F23823FA3014C1866E72CC4CD8B226CD6EF4" Finally, whether the object is found or not, if a valid index is computed, that index will be returned. This can be used to confirm the query was valid, or to save the index for future use. ci: remove 'master' branch as a trigger (#6234) This change removes the `master` branch as a trigger for the CI pipelines, and updates comments accordingly. It also fixes the pre-commit workflow, so it will run on all release branches.
1 parent 51f1fe5 commit 9fe50c9

File tree

1,355 files changed

+18483
-10515
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,355 files changed

+18483
-10515
lines changed

.config/cspell.config.yaml

Lines changed: 286 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,286 @@
1+
ignorePaths:
2+
- build/**
3+
- src/libxrpl/crypto
4+
- src/test/** # Will be removed in the future
5+
- CMakeUserPresets.json
6+
- Doxyfile
7+
- docs/**/*.puml
8+
- cmake/**
9+
- LICENSE.md
10+
language: en
11+
allowCompoundWords: true
12+
ignoreRandomStrings: true
13+
minWordLength: 5
14+
dictionaries:
15+
- cpp
16+
- en_US
17+
- en_GB
18+
ignoreRegExpList:
19+
- /[rs][1-9A-HJ-NP-Za-km-z]{25,34}/g # addresses and seeds
20+
- /(XRPL|BEAST)_[A-Z_0-9]+_H_INCLUDED+/g # include guards
21+
- /(XRPL|BEAST)_[A-Z_0-9]+_H+/g # include guards
22+
- /::[a-z:_]+/g # things from other namespaces
23+
- /lib[a-z]+/g # libraries
24+
- /[0-9]{4}-[0-9]{2}-[0-9]{2}[,:][A-Za-zÀ-ÖØ-öø-ÿ.\s]+/g # copyright dates
25+
- /[0-9]{4}[,:]?\s*[A-Za-zÀ-ÖØ-öø-ÿ.\s]+/g # copyright years
26+
- /\[[A-Za-z0-9-]+\]\(https:\/\/github.com\/[A-Za-z0-9-]+\)/g # Github usernames
27+
- /-[DWw][a-zA-Z0-9_-]+=/g # compile flags
28+
- /[\['"`]-[DWw][a-zA-Z0-9_-]+['"`\]]/g # compile flags
29+
suggestWords:
30+
- xprl->xrpl
31+
- xprld->xrpld
32+
- unsynched->unsynced
33+
- synched->synced
34+
- synch->sync
35+
words:
36+
- abempty
37+
- AMMID
38+
- amt
39+
- amts
40+
- asnode
41+
- asynchrony
42+
- attestation
43+
- authorises
44+
- autobridge
45+
- autobridged
46+
- autobridging
47+
- bimap
48+
- bindir
49+
- bookdir
50+
- Bougalis
51+
- Britto
52+
- Btrfs
53+
- canonicality
54+
- checkme
55+
- choco
56+
- chrono
57+
- citardauq
58+
- clawback
59+
- clawbacks
60+
- coeffs
61+
- coldwallet
62+
- compr
63+
- conanfile
64+
- conanrun
65+
- confs
66+
- connectability
67+
- coro
68+
- coros
69+
- cowid
70+
- cryptocondition
71+
- cryptoconditional
72+
- cryptoconditions
73+
- csprng
74+
- ctest
75+
- ctid
76+
- currenttxhash
77+
- daria
78+
- dcmake
79+
- dearmor
80+
- deleteme
81+
- demultiplexer
82+
- deserializaton
83+
- desync
84+
- desynced
85+
- determ
86+
- distro
87+
- doxyfile
88+
- dxrpl
89+
- endmacro
90+
- exceptioned
91+
- Falco
92+
- finalizers
93+
- firewalled
94+
- fmtdur
95+
- fsanitize
96+
- funclets
97+
- gcov
98+
- gcovr
99+
- ghead
100+
- Gnutella
101+
- gpgcheck
102+
- gpgkey
103+
- hotwallet
104+
- ifndef
105+
- inequation
106+
- insuf
107+
- insuff
108+
- iou
109+
- ious
110+
- isrdc
111+
- itype
112+
- jemalloc
113+
- jlog
114+
- keylet
115+
- keylets
116+
- keyvadb
117+
- ledgerentry
118+
- ledgerhash
119+
- ledgerindex
120+
- leftw
121+
- legleux
122+
- levelization
123+
- levelized
124+
- libpb
125+
- libxrpl
126+
- llection
127+
- LOCALGOOD
128+
- logwstream
129+
- lseq
130+
- lsmf
131+
- ltype
132+
- mcmodel
133+
- MEMORYSTATUSEX
134+
- Merkle
135+
- Metafuncton
136+
- misprediction
137+
- mptbalance
138+
- mptflags
139+
- mptid
140+
- mptissuance
141+
- mptissuanceid
142+
- mptoken
143+
- mptokenid
144+
- mptokenissuance
145+
- mptokens
146+
- mpts
147+
- multisig
148+
- multisign
149+
- multisigned
150+
- Nakamoto
151+
- nftid
152+
- nftoffer
153+
- nftoken
154+
- nftokenid
155+
- nftokenpages
156+
- nftokens
157+
- nftpage
158+
- nikb
159+
- nonxrp
160+
- noripple
161+
- nudb
162+
- nullptr
163+
- nunl
164+
- Nyffenegger
165+
- ostr
166+
- partitioner
167+
- paychan
168+
- paychans
169+
- permdex
170+
- perminute
171+
- permissioned
172+
- pointee
173+
- preauth
174+
- preauthorization
175+
- preauthorize
176+
- preauthorizes
177+
- preclaim
178+
- protobuf
179+
- protos
180+
- ptrs
181+
- pyenv
182+
- qalloc
183+
- queuable
184+
- Raphson
185+
- replayer
186+
- rerere
187+
- retriable
188+
- RIPD
189+
- ripdtop
190+
- rippleci
191+
- rippled
192+
- ripplerpc
193+
- rippletest
194+
- RLUSD
195+
- rngfill
196+
- rocksdb
197+
- Rohrs
198+
- roundings
199+
- sahyadri
200+
- Satoshi
201+
- scons
202+
- secp
203+
- sendq
204+
- seqit
205+
- sf
206+
- SFIELD
207+
- shamap
208+
- shamapitem
209+
- sidechain
210+
- SIGGOOD
211+
- sle
212+
- sles
213+
- soci
214+
- socidb
215+
- sslws
216+
- statsd
217+
- STATSDCOLLECTOR
218+
- stissue
219+
- stnum
220+
- stobj
221+
- stobject
222+
- stpath
223+
- stpathset
224+
- sttx
225+
- stvar
226+
- stvector
227+
- stxchainattestations
228+
- superpeer
229+
- superpeers
230+
- takergets
231+
- takerpays
232+
- ters
233+
- TMEndpointv2
234+
- trixie
235+
- tx
236+
- txid
237+
- txids
238+
- txjson
239+
- txn
240+
- txns
241+
- txs
242+
- UBSAN
243+
- ubsan
244+
- umant
245+
- unacquired
246+
- unambiguity
247+
- unauthorizes
248+
- unauthorizing
249+
- unergonomic
250+
- unfetched
251+
- unflatten
252+
- unfund
253+
- unimpair
254+
- unroutable
255+
- unscalable
256+
- unserviced
257+
- unshareable
258+
- unshares
259+
- unsquelch
260+
- unsquelched
261+
- unsquelching
262+
- unvalidated
263+
- unveto
264+
- unvetoed
265+
- upvotes
266+
- USDB
267+
- variadics
268+
- venv
269+
- vfalco
270+
- vinnie
271+
- wextra
272+
- wptr
273+
- writeme
274+
- wsrch
275+
- wthread
276+
- xbridge
277+
- xchain
278+
- ximinez
279+
- EXPECT_STREQ
280+
- XMACRO
281+
- xrpkuwait
282+
- xrpl
283+
- xrpld
284+
- xrplf
285+
- xxhash
286+
- xxhasher

.gitattributes

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
# Set default behaviour, in case users don't have core.autocrlf set.
22
#* text=auto
3-
4-
# These annoying files
5-
rippled.1 binary
6-
LICENSE binary
3+
# cspell: disable
74

85
# Visual Studio
96
*.sln text eol=crlf

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: Bug Report
3-
about: Create a report to help us improve rippled
4-
title: "[Title with short description] (Version: [rippled version])"
3+
about: Create a report to help us improve xrpld
4+
title: "[Title with short description] (Version: [xrpld version])"
55
labels: ""
66
assignees: ""
77
---
@@ -27,7 +27,7 @@ assignees: ""
2727
## Environment
2828

2929
<!--Please describe your environment setup (such as Ubuntu 18.04 with Boost 1.70).-->
30-
<!-- If you are using a formal release, please use the version returned by './rippled --version' as the version number-->
30+
<!-- If you are using a formal release, please use the version returned by './xrpld --version' as the version number-->
3131
<!-- If you are working off of develop, please add the git hash via 'git rev-parse HEAD'-->
3232

3333
## Supporting Files

.github/actions/build-deps/action.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ description: "Install Conan dependencies, optionally forcing a rebuild of all de
44
# Note that actions do not support 'type' and all inputs are strings, see
55
# https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax#inputs.
66
inputs:
7-
build_dir:
8-
description: "The directory where to build."
9-
required: true
107
build_type:
118
description: 'The build type to use ("Debug", "Release").'
129
required: true
@@ -21,29 +18,31 @@ inputs:
2118
description: "The logging verbosity."
2219
required: false
2320
default: "verbose"
21+
sanitizers:
22+
description: "The sanitizers to enable."
23+
required: false
24+
default: ""
2425

2526
runs:
2627
using: composite
2728
steps:
2829
- name: Install Conan dependencies
2930
shell: bash
3031
env:
31-
BUILD_DIR: ${{ inputs.build_dir }}
3232
BUILD_NPROC: ${{ inputs.build_nproc }}
3333
BUILD_OPTION: ${{ inputs.force_build == 'true' && '*' || 'missing' }}
3434
BUILD_TYPE: ${{ inputs.build_type }}
3535
LOG_VERBOSITY: ${{ inputs.log_verbosity }}
36+
SANITIZERS: ${{ inputs.sanitizers }}
3637
run: |
3738
echo 'Installing dependencies.'
38-
mkdir -p "${BUILD_DIR}"
39-
cd "${BUILD_DIR}"
4039
conan install \
41-
--output-folder . \
40+
--profile ci \
4241
--build="${BUILD_OPTION}" \
4342
--options:host='&:tests=True' \
4443
--options:host='&:xrpld=True' \
4544
--settings:all build_type="${BUILD_TYPE}" \
4645
--conf:all tools.build:jobs=${BUILD_NPROC} \
4746
--conf:all tools.build:verbosity="${LOG_VERBOSITY}" \
4847
--conf:all tools.compilation:verbosity="${LOG_VERBOSITY}" \
49-
..
48+
.

0 commit comments

Comments
 (0)