Revert "Fix some review comments"

This reverts commit 58e429f.

Author: godexsoft

src/libxrpl/beast/insight/Groups.cpp

@@ -32,9 +32,6 @@ class GroupImp : public std::enable_shared_from_this<GroupImp>, public Group
 
     ~GroupImp() = default;
 
-    GroupImp&
-    operator=(GroupImp const&) = delete;
-
     std::string const&
     name() const override
     {
@@ -76,6 +73,10 @@ class GroupImp : public std::enable_shared_from_this<GroupImp>, public Group
     {
         return m_collector->make_meter(make_name(name));
     }
+
+private:
+    GroupImp&
+    operator=(GroupImp const&);
 };
 
 //------------------------------------------------------------------------------
@@ -92,6 +93,8 @@ class GroupsImp : public Groups
     {
     }
 
+    ~GroupsImp() = default;
+
     Group::ptr const&
     get(std::string const& name) override
     {

src/libxrpl/beast/insight/NullCollector.cpp

@@ -24,8 +24,9 @@ class NullHookImpl : public HookImpl
 public:
     explicit NullHookImpl() = default;
 
+private:
     NullHookImpl&
-    operator=(NullHookImpl const&) = delete;
+    operator=(NullHookImpl const&);
 };
 
 //------------------------------------------------------------------------------
@@ -35,13 +36,14 @@ class NullCounterImpl : public CounterImpl
 public:
     explicit NullCounterImpl() = default;
 
-    NullCounterImpl&
-    operator=(NullCounterImpl const&) = delete;
-
     void
     increment(value_type) override
     {
     }
+
+private:
+    NullCounterImpl&
+    operator=(NullCounterImpl const&);
 };
 
 //------------------------------------------------------------------------------
@@ -51,13 +53,14 @@ class NullEventImpl : public EventImpl
 public:
     explicit NullEventImpl() = default;
 
-    NullEventImpl&
-    operator=(NullEventImpl const&) = delete;
-
     void
     notify(value_type const&) override
     {
     }
+
+private:
+    NullEventImpl&
+    operator=(NullEventImpl const&);
 };
 
 //------------------------------------------------------------------------------
@@ -67,9 +70,6 @@ class NullGaugeImpl : public GaugeImpl
 public:
     explicit NullGaugeImpl() = default;
 
-    NullGaugeImpl&
-    operator=(NullGaugeImpl const&) = delete;
-
     void
     set(value_type) override
     {
@@ -79,6 +79,10 @@ class NullGaugeImpl : public GaugeImpl
     increment(difference_type) override
     {
     }
+
+private:
+    NullGaugeImpl&
+    operator=(NullGaugeImpl const&);
 };
 
 //------------------------------------------------------------------------------
@@ -88,13 +92,14 @@ class NullMeterImpl : public MeterImpl
 public:
     explicit NullMeterImpl() = default;
 
-    NullMeterImpl&
-    operator=(NullMeterImpl const&) = delete;
-
     void
     increment(value_type) override
     {
     }
+
+private:
+    NullMeterImpl&
+    operator=(NullMeterImpl const&);
 };
 
 //------------------------------------------------------------------------------

src/libxrpl/beast/insight/StatsDCollector.cpp

@@ -85,10 +85,8 @@ class StatsDCounterImpl : public CounterImpl, public StatsDMetricBase
 {
 public:
     StatsDCounterImpl(std::string const& name, std::shared_ptr<StatsDCollectorImp> const& impl);
-    ~StatsDCounterImpl() override;
 
-    StatsDCounterImpl&
-    operator=(StatsDCounterImpl const&) = delete;
+    ~StatsDCounterImpl() override;
 
     void
     increment(CounterImpl::value_type amount) override;
@@ -101,6 +99,9 @@ class StatsDCounterImpl : public CounterImpl, public StatsDMetricBase
     do_process() override;
 
 private:
+    StatsDCounterImpl&
+    operator=(StatsDCounterImpl const&);
+
     std::shared_ptr<StatsDCollectorImp> m_impl;
     std::string m_name;
     CounterImpl::value_type m_value;
@@ -113,10 +114,8 @@ class StatsDEventImpl : public EventImpl
 {
 public:
     StatsDEventImpl(std::string const& name, std::shared_ptr<StatsDCollectorImp> const& impl);
-    ~StatsDEventImpl() = default;
 
-    StatsDEventImpl&
-    operator=(StatsDEventImpl const&) = delete;
+    ~StatsDEventImpl() = default;
 
     void
     notify(EventImpl::value_type const& value) override;
@@ -127,6 +126,9 @@ class StatsDEventImpl : public EventImpl
     do_process();
 
 private:
+    StatsDEventImpl&
+    operator=(StatsDEventImpl const&);
+
     std::shared_ptr<StatsDCollectorImp> m_impl;
     std::string m_name;
 };
@@ -137,10 +139,8 @@ class StatsDGaugeImpl : public GaugeImpl, public StatsDMetricBase
 {
 public:
     StatsDGaugeImpl(std::string const& name, std::shared_ptr<StatsDCollectorImp> const& impl);
-    ~StatsDGaugeImpl() override;
 
-    StatsDGaugeImpl&
-    operator=(StatsDGaugeImpl const&) = delete;
+    ~StatsDGaugeImpl() override;
 
     void
     set(GaugeImpl::value_type value) override;
@@ -157,6 +157,9 @@ class StatsDGaugeImpl : public GaugeImpl, public StatsDMetricBase
     do_process() override;
 
 private:
+    StatsDGaugeImpl&
+    operator=(StatsDGaugeImpl const&);
+
     std::shared_ptr<StatsDCollectorImp> m_impl;
     std::string m_name;
     GaugeImpl::value_type m_last_value;
@@ -175,9 +178,6 @@ class StatsDMeterImpl : public MeterImpl, public StatsDMetricBase
 
     ~StatsDMeterImpl() override;
 
-    StatsDMeterImpl&
-    operator=(StatsDMeterImpl const&) = delete;
-
     void
     increment(MeterImpl::value_type amount) override;
 
@@ -189,6 +189,9 @@ class StatsDMeterImpl : public MeterImpl, public StatsDMetricBase
     do_process() override;
 
 private:
+    StatsDMeterImpl&
+    operator=(StatsDMeterImpl const&);
+
     std::shared_ptr<StatsDCollectorImp> m_impl;
     std::string m_name;
     MeterImpl::value_type m_value;