Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction and ledger entry formats to server_definitions #5151

Open
mvadari opened this issue Oct 2, 2024 · 3 comments
Open

Add transaction and ledger entry formats to server_definitions #5151

mvadari opened this issue Oct 2, 2024 · 3 comments
Labels
API Change Feature Request Used to indicate requests to add new features

Comments

@mvadari
Copy link
Collaborator

mvadari commented Oct 2, 2024

Summary

The server_definitions RPC returns all the fields, transaction types, ledger entry types, etc. that the server knows about. This PR suggests adding the transaction formats and ledger formats to this RPC as well.

Motivation

This will provide a canonical source of truth for the transactions and ledger entry type fields.

Solution

Amend the server_definitions RPC to include this info.

Paths Not Taken

You can parse source code as-is (for example, this script in xrpl.js does so). There may be an OpenAPI-related path as well.

@dangell7
Copy link
Collaborator

dangell7 commented Oct 2, 2024

We could also add the tx flags

@donovanhide
Copy link
Contributor

Ledger Entry Flags too :-)

@thejohnfreeman
Copy link
Collaborator

I prefer the source code solution as well, with the build system generating the corresponding header and implementation files for xrpld. I just don't have the time personally to devote to building it out. It can be a great project for a new contributor or intern though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

4 participants