OrderBookDB::update is not getting triggered (Version: 2.5.n...2.6.n) #6052
Description
Issue Description
On both UNL and non-UNL validators on Mainnet, we haven’t seen a single OrderBookDB::update job in the debug logs over the last 30 days. We only keep debug logs for 30 days and can't be sure when the regression started.
Based on the current gating logic, OrderBookDB::update appears intended to run roughly every 25,600 ledgers (≈21 hours at ~3 seconds per ledger). Over 30 days of Mainnet operation, we’d therefore expect on the order of 30–40 updates, not zero.
This behavior is likely related to the logic typo reported in #4790, where the comparison and subtraction in the sequence check appear to be inverted.
Not having OrderBookDB::update run does not affect consensus or ledger correctness, but it may have adverse performance impact: order book and pathfinding operations can become progressively more expensive as the in-memory order book index drifts and the server falls back to more expensive lookups.