address code rabbit suggestions

Author: ckeshava

tests/unit/core/binarycodec/types/test_int32.py

@@ -4,7 +4,7 @@
 from xrpl.core.binarycodec.types.int32 import Int32
 
 
-class TestUInt(TestCase):
+class TestInt32(TestCase):
     def test_compare_INT32(self):
         value1 = Int32.from_value(124)
         value2 = Int32.from_value(123)

tests/unit/models/transactions/test_loan_pay.py

@@ -36,7 +36,7 @@ def test_invalid_flag_input(self):
             "{'LoanPay:Flags': 'Unrecognised flag in the LoanPay " + "transaction'}",
         )
 
-    def test_valid_loan_set(self):
+    def test_valid_loan_pay(self):
         tx = LoanPay(
             account=_SOURCE,
             loan_id=_LOAN_ID,

tests/unit/models/transactions/test_vault_create.py

@@ -122,3 +122,33 @@ def test_tx_emits_warning_for_missing_icon_metadata(self):
                 "- uris/us: should be an array of objects each "
                 "with uri/u, category/c, and title/t properties.",
             )
+
+    def test_scale_field_too_large(self):
+        with self.assertRaises(XRPLModelException) as error:
+            VaultCreate(
+                account=_ACCOUNT,
+                asset=IssuedCurrency(currency="USD", issuer=_ACCOUNT),
+                assets_maximum="1000",
+                withdrawal_policy=1,
+                data=str_to_hex("A" * 256),
+                scale=18 + 1,
+            )
+        self.assertEqual(
+            error.exception.args[0],
+            "{'VaultCreate': 'Scale field is higher than the allowed limit (18)'}",
+        )
+
+    def test_scale_field_too_small(self):
+        with self.assertRaises(XRPLModelException) as error:
+            VaultCreate(
+                account=_ACCOUNT,
+                asset=IssuedCurrency(currency="USD", issuer=_ACCOUNT),
+                assets_maximum="1000",
+                withdrawal_policy=1,
+                data=str_to_hex("A" * 256),
+                scale=-1,
+            )
+        self.assertEqual(
+            error.exception.args[0],
+            "{'VaultCreate': 'Scale field is lower than the allowed limit (0)'}",
+        )

tests/unit/models/transactions/test_vault_withdraw.py

@@ -6,6 +6,7 @@
 
 _ACCOUNT = "rsA2LpzuawewSBQXkiju3YQTMzW13pAAdW"
 _VAULT_ID = "B982D2AAEF6014E6BE3194D939865453D56D16FF7081BB1D0ED865C708ABCEEE"
+_DESTINATION = "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn"
 
 
 class TestVaultWithdraw(TestCase):
@@ -22,6 +23,7 @@ def test_valid_with_destination_tag(self):
             account=_ACCOUNT,
             vault_id=_VAULT_ID,
             amount=IssuedCurrencyAmount(currency="USD", issuer=_ACCOUNT, value="100"),
+            destination=_DESTINATION,
             destination_tag=3000,
         )
         self.assertTrue(tx.is_valid())

xrpl/models/transactions/loan_pay.py

@@ -17,7 +17,7 @@
 
 class LoanPayFlag(int, Enum):
     """
-    Enum for LoanPAY Transaction Flags.
+    Enum for LoanPay Transaction Flags.
 
     Transactions of the LoanPay type support additional values in the flags field
     """
@@ -40,13 +40,13 @@ class LoanPayFlag(int, Enum):
 
 class LoanPayFlagInterface(TransactionFlagInterface):
     """
-    Transactions of the LoanManage type support additional values in the Flags field.
+    Transactions of the LoanPay type support additional values in the Flags field.
     This TypedDict represents those options.
     """
 
-    TF_LOAN_DEFAULT: bool
-    TF_LOAN_IMPAIR: bool
-    TF_LOAN_UNIMPAIR: bool
+    TF_LOAN_OVERPAYMENT: bool
+    TF_LOAN_FULL_PAYMENT: bool
+    TF_LOAN_LATE_PAYMENT: bool
 
 
 @require_kwargs_on_init
@@ -79,9 +79,7 @@ def _get_errors(self: Self) -> Dict[str, str]:
         if self.flags is not None and isinstance(self.flags, int):
             # Check for unrecognized flags (bits set outside valid mask)
             if self.flags & ~self._VALID_FLAGS_MASK:
-                errors[
-                    "LoanPay:Flags"
-                ] = "Unrecognised flag in the LoanPay transaction"
+                errors["LoanPay:Flags"] = "Unrecognised flag in the LoanPay transaction"
             # Check that at most one flag is enabled
             elif bin(self.flags & self._VALID_FLAGS_MASK).count("1") > 1:
                 errors["LoanPay:Flags"] = (

xrpl/models/transactions/vault_create.py

@@ -132,6 +132,16 @@ def _get_errors(self: Self) -> Dict[str, str]:
                 "Invalid domain ID: Length must be 32 characters (64 hex characters)."
             )
 
+        if self.scale is not None:
+            if self.scale > 18:
+                errors["VaultCreate"] = (
+                    "Scale field is higher than the allowed limit (18)"
+                )
+            elif self.scale < 0:
+                errors["VaultCreate"] = (
+                    "Scale field is lower than the allowed limit (0)"
+                )
+
         if self.mptoken_metadata is not None:
             # Lazy import to avoid circular dependency
             from xrpl.utils.mptoken_metadata import validate_mptoken_metadata