feat: Additional validation for AMMClawback transaction with mpt asset

Author: ckeshava

tests/unit/models/transactions/test_amm_clawback.py

@@ -98,6 +98,45 @@ def test_valid_mpt_clawback_without_amount(self):
         )
         self.assertTrue(txn.is_valid())
 
+    def test_mpt_clawback_amount_type_mismatch(self):
+        """asset is MPTCurrency but amount is IssuedCurrencyAmount."""
+        with self.assertRaises(XRPLModelException) as error:
+            AMMClawback(
+                account=_ISSUER_ACCOUNT,
+                holder=_HOLDER_ACCOUNT,
+                asset=MPTCurrency(mpt_issuance_id=_MPT_ISSUANCE_ID_1),
+                asset2=MPTCurrency(mpt_issuance_id=_MPT_ISSUANCE_ID_2),
+                amount=IssuedCurrencyAmount(
+                    currency="ETH",
+                    issuer=_ISSUER_ACCOUNT,
+                    value="100",
+                ),
+            )
+        self.assertEqual(
+            error.exception.args[0],
+            "{'AMMClawback': 'Mismatch between Asset and Amount Currency types. "
+            + "Asset is MPTCurrency whereas Amount is not.'}",
+        )
+
+    def test_mpt_clawback_mismatched_issuance_id(self):
+        """asset and amount are both MPT but have different mpt_issuance_id."""
+        with self.assertRaises(XRPLModelException) as error:
+            AMMClawback(
+                account=_ISSUER_ACCOUNT,
+                holder=_HOLDER_ACCOUNT,
+                asset=MPTCurrency(mpt_issuance_id=_MPT_ISSUANCE_ID_1),
+                asset2=MPTCurrency(mpt_issuance_id=_MPT_ISSUANCE_ID_2),
+                amount=MPTAmount(
+                    mpt_issuance_id=_MPT_ISSUANCE_ID_2,
+                    value="10",
+                ),
+            )
+        self.assertEqual(
+            error.exception.args[0],
+            "{'AMMClawback': 'Mismatch in the Asset.mpt_issuance_id and "
+            + "Amount.mpt_issuance_id fields'}",
+        )
+
     def test_mpt_clawback_non_hex_characters(self):
         bad_id = "Z" * MPT_ISSUANCE_ID_LENGTH
         with self.assertRaises(XRPLModelException) as error:

xrpl/models/transactions/amm_clawback.py

@@ -8,7 +8,7 @@
 
 from typing_extensions import Self
 
-from xrpl.models.amounts import Amount, IssuedCurrencyAmount
+from xrpl.models.amounts import Amount, IssuedCurrencyAmount, MPTAmount
 from xrpl.models.currencies import Currency, IssuedCurrency, MPTCurrency
 from xrpl.models.required import REQUIRED
 from xrpl.models.transactions.transaction import Transaction, TransactionFlagInterface
@@ -113,4 +113,17 @@ def _validate_wallet_and_amount_fields(self: Self) -> Optional[str]:
                     + "fields."
                 )
 
+        if isinstance(self.asset, MPTCurrency):
+            if self.amount is not None:
+                if not isinstance(self.amount, MPTAmount):
+                    errors += (
+                        "Mismatch between Asset and Amount Currency types. Asset "
+                        + "is MPTCurrency whereas Amount is not."
+                    )
+                elif self.amount.mpt_issuance_id != self.asset.mpt_issuance_id:
+                    errors += (
+                        "Mismatch in the Asset.mpt_issuance_id and "
+                        + "Amount.mpt_issuance_id fields"
+                    )
+
         return errors if errors else None