fix: widen transactions type to include hash strings, normalize v1 in hashTxTree

- Widen Ledger.transactions and LedgerV1.transactions to
  Array<string | Expanded> to reflect both non-expanded (hash strings)
  and expanded response shapes
- Replace unsafe cast in computeTransactionHash with proper v1→v2
  normalization: detect LedgerTransactionExpandedV1 wrappers and
  extract tx_json/meta into the flat format expected by hashTxTree
- Add missing Amount/Destination fields to Payment test fixtures
- Add test case for hash-string transactions
- Guard test assertions for string | object union type

Author: slurpyone

packages/xrpl/src/models/ledger/Ledger.ts

@@ -96,7 +96,7 @@ export interface Ledger extends BaseLedger {
    * full representations of the transactions as flat objects with the
    * transaction fields directly on the object, plus `hash` and `metaData`.
    */
-  transactions?: Array<LedgerTransactionExpanded>
+  transactions?: Array<string | LedgerTransactionExpanded>
 }
 
 /**
@@ -117,7 +117,7 @@ export interface LedgerV1 extends BaseLedger {
    * full representations of the transactions wrapped in objects with
    * `tx_json` and `meta` fields.
    */
-  transactions?: Array<LedgerTransactionExpandedV1>
+  transactions?: Array<string | LedgerTransactionExpandedV1>
 }
 
 /**

packages/xrpl/src/utils/hashes/hashLedger.ts

@@ -13,6 +13,7 @@ import { LedgerEntry } from '../../models/ledger'
 import {
   LedgerVersionMap,
   LedgerTransactionExpanded,
+  LedgerTransactionExpandedV1,
 } from '../../models/ledger/Ledger'
 import { Transaction } from '../../models/transactions'
 import { GlobalFlags } from '../../models/transactions/common'
@@ -180,9 +181,32 @@ function computeTransactionHash(
     throw new ValidationError('transactions is missing from the ledger')
   }
 
-  const transactionHash = hashTxTree(
-    ledger.transactions as LedgerTransactionExpanded[],
+    // Normalize transactions to the v2 flat format expected by hashTxTree.
+  // V1 expanded transactions wrap data in { tx_json, meta }, while v2 has
+  // the transaction fields directly on the object with metaData.
+  const normalizedTransactions = (
+    ledger.transactions as Array<
+      string | LedgerTransactionExpanded | LedgerTransactionExpandedV1
+    >
   )
+    .filter(
+      (
+        tx,
+      ): tx is LedgerTransactionExpanded | LedgerTransactionExpandedV1 =>
+        typeof tx !== 'string',
+    )
+    .map((tx) => {
+      if ('tx_json' in tx) {
+        // V1 wrapped format — normalize to v2 flat format
+        return Object.assign({}, tx.tx_json, {
+          hash: tx.hash,
+          metaData: tx.meta,
+        }) as LedgerTransactionExpanded
+      }
+      return tx
+    })
+
+  const transactionHash = hashTxTree(normalizedTransactions)
 
   if (transaction_hash !== transactionHash) {
     throw new ValidationError(

packages/xrpl/test/models/LedgerTransactionExpanded.test.ts

@@ -11,6 +11,8 @@ describe('LedgerTransactionExpanded types', function () {
   it('Ledger (v2) transactions use flat format with metaData', function () {
     const tx: LedgerTransactionExpanded = {
       Account: 'rPrioTXJgZJF8bpdXq2X73PcVPfvYqjVKd',
+      Amount: '1000000',
+      Destination: 'rsRy14FvipgqudiGmptJBhr1RtpsgfzKMM',
       TransactionType: 'Payment',
       Fee: '11',
       Sequence: 1,
@@ -31,14 +33,31 @@ describe('LedgerTransactionExpanded types', function () {
     }
 
     assert.isArray(ledgerV2.transactions)
-    assert.strictEqual(ledgerV2.transactions![0].hash, tx.hash)
-    assert.isDefined(ledgerV2.transactions![0].metaData)
+    const firstTx = ledgerV2.transactions![0]
+    assert.notEqual(typeof firstTx, 'string')
+    if (typeof firstTx !== 'string') {
+      assert.strictEqual(firstTx.hash, tx.hash)
+      assert.isDefined(firstTx.metaData)
+    }
+  })
+
+  it('Ledger transactions can also be hash strings', function () {
+    const ledgerV2: Pick<Ledger, 'transactions'> = {
+      transactions: [
+        '044314FE34236A262DA692789CE5B48CA1A3CEC078B1A4ECCD65F4B61A9EB0A7',
+      ],
+    }
+
+    assert.isArray(ledgerV2.transactions)
+    assert.strictEqual(typeof ledgerV2.transactions![0], 'string')
   })
 
   it('LedgerV1 transactions use wrapped format with tx_json and meta', function () {
     const tx: LedgerTransactionExpandedV1 = {
       tx_json: {
         Account: 'rPrioTXJgZJF8bpdXq2X73PcVPfvYqjVKd',
+        Amount: '1000000',
+        Destination: 'rsRy14FvipgqudiGmptJBhr1RtpsgfzKMM',
         TransactionType: 'Payment',
         Fee: '11',
         Sequence: 1,
@@ -65,8 +84,12 @@ describe('LedgerTransactionExpanded types', function () {
     }
 
     assert.isArray(ledgerV1.transactions)
-    assert.strictEqual(ledgerV1.transactions![0].hash, tx.hash)
-    assert.isDefined(ledgerV1.transactions![0].tx_json)
-    assert.isDefined(ledgerV1.transactions![0].meta)
+    const firstTx = ledgerV1.transactions![0]
+    assert.notEqual(typeof firstTx, 'string')
+    if (typeof firstTx !== 'string') {
+      assert.strictEqual(firstTx.hash, tx.hash)
+      assert.isDefined(firstTx.tx_json)
+      assert.isDefined(firstTx.meta)
+    }
   })
 })