fix: update LedgerResponseExpanded type for APIv2

Split expanded transaction types for Ledger (v2) and LedgerV1:

- v2: transactions are flat objects with hash and metaData fields
- v1: transactions are wrapped in { tx_json, meta, hash, ... }

Add LedgerTransactionExpanded and LedgerTransactionExpandedV1 types
to accurately reflect the different response structures.

Move transactions property from BaseLedger to Ledger/LedgerV1 with
the correct type for each API version.

Update hashTxTree to use the new LedgerTransactionExpanded type.

Fixes #2886

Author: slurpyone

packages/xrpl/src/models/ledger/Ledger.ts

@@ -54,19 +54,30 @@ interface BaseLedger {
   total_coins: string
   /** Hash of the transaction information included in this ledger, as hex. */
   transaction_hash: string
-  /**
-   * Transactions applied in this ledger version. By default, members are the
-   * transactions' identifying Hash strings. If the request specified expand as
-   * true, members are full representations of the transactions instead, in
-   * either JSON or binary depending on whether the request specified binary
-   * as true.
-   */
-  transactions?: Array<
-    Transaction & {
-      hash: string
-      metaData?: TransactionMetadata
-    }
-  >
+}
+
+/**
+ * Expanded transaction format in API version 2.
+ * Transactions are returned as flat objects with the transaction fields
+ * directly on the object, plus `hash` and `metaData`.
+ */
+export type LedgerTransactionExpanded = Transaction & {
+  hash: string
+  metaData?: TransactionMetadata
+}
+
+/**
+ * Expanded transaction format in API version 1.
+ * Transactions are wrapped in an object with `tx_json` and `meta` fields.
+ */
+export interface LedgerTransactionExpandedV1 {
+  tx_json: Transaction
+  meta: TransactionMetadata
+  hash: string
+  validated: boolean
+  ledger_index: number
+  close_time_iso: string
+  ledger_hash: string
 }
 
 /**
@@ -80,6 +91,14 @@ export interface Ledger extends BaseLedger {
    * The ledger index of the ledger. Represented as a number.
    */
   ledger_index: number
+  /**
+   * Transactions applied in this ledger version. By default, members are the
+   * transactions' identifying Hash strings. If the request specified expand as
+   * true, members are full representations of the transactions instead, in
+   * either JSON or binary depending on whether the request specified binary
+   * as true.
+   */
+  transactions?: Array<LedgerTransactionExpanded>
 }
 
 /**
@@ -95,6 +114,13 @@ export interface LedgerV1 extends BaseLedger {
    * integer; some display it as a number.
    */
   ledger_index: string
+  /**
+   * Transactions applied in this ledger version. By default, members are the
+   * transactions' identifying Hash strings. If the request specified expand as
+   * true, members are full representations of the transactions instead,
+   * wrapped in objects with `tx_json` and `meta` fields.
+   */
+  transactions?: Array<LedgerTransactionExpandedV1>
 }
 
 /**

packages/xrpl/src/models/ledger/index.ts

@@ -17,7 +17,12 @@ import FeeSettings, {
   FeeSettingsPostAmendmentFields,
   FEE_SETTINGS_ID,
 } from './FeeSettings'
-import { Ledger, LedgerV1 } from './Ledger'
+import {
+  Ledger,
+  LedgerV1,
+  LedgerTransactionExpanded,
+  LedgerTransactionExpandedV1,
+} from './Ledger'
 import { LedgerEntry, LedgerEntryFilter } from './LedgerEntry'
 import LedgerHashes from './LedgerHashes'
 import Loan, { LoanFlags } from './Loan'
@@ -58,6 +63,8 @@ export {
   FeeSettingsPostAmendmentFields,
   Ledger,
   LedgerV1,
+  LedgerTransactionExpanded,
+  LedgerTransactionExpandedV1,
   LedgerEntryFilter,
   LedgerEntry,
   LedgerHashes,

packages/xrpl/src/utils/hashes/hashLedger.ts

@@ -10,8 +10,11 @@ import { decode, encode } from 'ripple-binary-codec'
 import { ValidationError, XrplError } from '../../errors'
 import { APIVersion } from '../../models'
 import { LedgerEntry } from '../../models/ledger'
-import { LedgerVersionMap } from '../../models/ledger/Ledger'
-import { Transaction, TransactionMetadata } from '../../models/transactions'
+import {
+  LedgerVersionMap,
+  LedgerTransactionExpanded,
+} from '../../models/ledger/Ledger'
+import { Transaction } from '../../models/transactions'
 import { GlobalFlags } from '../../models/transactions/common'
 import { hasFlag } from '../../models/utils'
 
@@ -131,7 +134,7 @@ export function hashLedgerHeader(
  * @category Utilities
  */
 export function hashTxTree(
-  transactions: Array<Transaction & { metaData?: TransactionMetadata }>,
+  transactions: LedgerTransactionExpanded[],
 ): string {
   const shamap = new SHAMap()
   for (const txJSON of transactions) {
@@ -177,7 +180,9 @@ function computeTransactionHash(
     throw new ValidationError('transactions is missing from the ledger')
   }
 
-  const transactionHash = hashTxTree(ledger.transactions)
+  const transactionHash = hashTxTree(
+    ledger.transactions as LedgerTransactionExpanded[],
+  )
 
   if (transaction_hash !== transactionHash) {
     throw new ValidationError(