lint

Author: achowdhry-ripple

packages/xrpl/src/models/methods/index.ts

@@ -1,6 +1,5 @@
 /* eslint-disable no-inline-comments -- Necessary for important note */
 /* eslint-disable max-lines -- There is a lot to export */
-/* eslint-disable prettier/prettier -- Required here to keep formatting in line */
 import type { APIVersion, DEFAULT_API_VERSION } from '../common'
 
 import {
@@ -37,17 +36,17 @@ import {
   AccountObjectsResponse,
   AccountObjectType,
 } from './accountObjects'
+import {
+  AccountOffer,
+  AccountOffersRequest,
+  AccountOffersResponse,
+} from './accountOffers'
 import {
   AccountSponsoringObjectType,
   AccountSponsoringRequest,
   AccountSponsoringResponse,
   SponsoredObject,
 } from './accountSponsoring'
-import {
-  AccountOffer,
-  AccountOffersRequest,
-  AccountOffersResponse,
-} from './accountOffers'
 import {
   AccountTxRequest,
   AccountTxResponse,

packages/xrpl/src/models/transactions/common.ts

@@ -721,9 +721,12 @@ export function validateBaseTransaction(
 
   // Validate SponsorFlags has valid values
   if (hasSponsorFlags) {
-    const validFlags = SponsorFlags.tfSponsorFee | SponsorFlags.tfSponsorReserve
-    const flags = common.SponsorFlags as number
-    if ((flags & ~validFlags) !== 0 || flags === 0) {
+    const flags = Number(common.SponsorFlags)
+    const isValidFlag =
+      flags === SponsorFlags.tfSponsorFee ||
+      flags === SponsorFlags.tfSponsorReserve ||
+      flags === SponsorFlags.tfSponsorFee + SponsorFlags.tfSponsorReserve
+    if (!isValidFlag) {
       throw new ValidationError(
         'BaseTransaction: invalid SponsorFlags - must include tfSponsorFee and/or tfSponsorReserve',
       )

packages/xrpl/src/models/transactions/sponsorshipSet.ts

@@ -148,12 +148,10 @@ export function validateSponsorshipSet(tx: Record<string, unknown>): void {
   validateOptionalField(tx, 'ReserveCount', isNumber)
 
   // Validate flag combinations with tfDeleteObject
-  const flags =
-    typeof tx.Flags === 'number' ? tx.Flags : 0
-
+  const flags = typeof tx.Flags === 'number' ? tx.Flags : 0
   const tfDeleteObject = SponsorshipSetFlags.tfDeleteObject
 
-  if ((flags & tfDeleteObject) !== 0) {
+  if (flags === tfDeleteObject) {
     // When deleting, cannot specify FeeAmount, MaxFee, or ReserveCount
     if (tx.FeeAmount !== undefined) {
       throw new ValidationError(
@@ -172,4 +170,3 @@ export function validateSponsorshipSet(tx: Record<string, unknown>): void {
     }
   }
 }
-

packages/xrpl/src/models/transactions/sponsorshipTransfer.ts

@@ -57,13 +57,10 @@ export interface SponsorshipTransfer extends BaseTransaction {
  * @param tx - A SponsorshipTransfer Transaction.
  * @throws When the SponsorshipTransfer is malformed.
  */
-export function validateSponsorshipTransfer(
-  tx: Record<string, unknown>,
-): void {
+export function validateSponsorshipTransfer(tx: Record<string, unknown>): void {
   validateBaseTransaction(tx)
 
   validateOptionalField(tx, 'ObjectID', isString)
   validateOptionalField(tx, 'Sponsor', isAccount)
   validateOptionalField(tx, 'SponsorFlags', isNumber)
 }
-

packages/xrpl/test/models/sponsorship.test.ts

@@ -1,15 +1,15 @@
 import { assert } from 'chai'
 
+import AccountRoot from '../../src/models/ledger/AccountRoot'
+import { BaseLedgerEntry } from '../../src/models/ledger/BaseLedgerEntry'
+import Check from '../../src/models/ledger/Check'
+import Escrow from '../../src/models/ledger/Escrow'
+import Offer from '../../src/models/ledger/Offer'
 import {
   AccountObjectsRequest,
   AccountSponsoringRequest,
   AccountSponsoringResponse,
 } from '../../src/models/methods'
-import Check from '../../src/models/ledger/Check'
-import Escrow from '../../src/models/ledger/Escrow'
-import Offer from '../../src/models/ledger/Offer'
-import AccountRoot from '../../src/models/ledger/AccountRoot'
-import { BaseLedgerEntry } from '../../src/models/ledger/BaseLedgerEntry'
 
 /**
  * Tests for XLS-0068 Sponsorship Feature Changes.