use typeName

Author: Patel-Raj11

packages/ripple-binary-codec/src/types/int-32.ts

@@ -41,17 +41,17 @@ class Int32 extends Int {
     const buf = new Uint8Array(Int32.width)
 
     if (typeof val === 'string') {
-      const num = Number.parseInt(val, 10)
-      if (!Number.isInteger(num)) {
+      const num = Number(val)
+      if (!Number.isFinite(num) || !Number.isInteger(num)) {
         throw new Error(`Cannot construct Int32 from string: ${val}`)
       }
-      Int32.checkIntRange(num, Int32.MIN_VALUE, Int32.MAX_VALUE)
+      Int32.checkIntRange('Int32', num, Int32.MIN_VALUE, Int32.MAX_VALUE)
       writeInt32BE(buf, num, 0)
       return new Int32(buf)
     }
 
     if (typeof val === 'number' && Number.isInteger(val)) {
-      Int32.checkIntRange(val, Int32.MIN_VALUE, Int32.MAX_VALUE)
+      Int32.checkIntRange('Int32', val, Int32.MIN_VALUE, Int32.MAX_VALUE)
       writeInt32BE(buf, val, 0)
       return new Int32(buf)
     }

packages/ripple-binary-codec/src/types/int.ts

@@ -51,19 +51,21 @@ abstract class Int extends Comparable<Int | number> {
   /**
    * Validate that a number is within the specified signed integer range
    *
+   * @param typeName The name of the type (for error messages)
    * @param val The number to validate
    * @param min The minimum allowed value
    * @param max The maximum allowed value
    * @throws Error if the value is out of range
    */
   static checkIntRange(
+    typeName: string,
     val: number | bigint,
     min: number | bigint,
     max: number | bigint,
   ): void {
     if (val < min || val > max) {
       throw new Error(
-        `Invalid ${this.name}: ${val} must be >= ${min} and <= ${max}`,
+        `Invalid ${typeName}: ${val} must be >= ${min} and <= ${max}`,
       )
     }
   }

packages/ripple-binary-codec/test/int.test.ts

@@ -98,6 +98,12 @@ describe('Int32', () => {
       )
     })
 
+    it('should throw error for decimal string', () => {
+      expect(() => Int32.from('1.23')).toThrow(
+        new Error('Cannot construct Int32 from string: 1.23'),
+      )
+    })
+
     it('should throw error for non-numeric string', () => {
       expect(() => Int32.from('abc')).toThrow(
         new Error('Cannot construct Int32 from string: abc'),