Fix checkstyle

Author: sappenin

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/EscrowIT.java

@@ -95,17 +95,6 @@ public void createAndFinishTimeBasedEscrow() throws JsonRpcClientErrorException,
       createResult.transactionResult().hash()
     );
 
-    //////////////////////
-    // Then wait until the transaction gets committed to a validated ledger
-    TransactionResult<EscrowCreate> result = this.scanForResult(
-      () -> this.getValidatedTransaction(createResult.transactionResult().hash(), EscrowCreate.class)
-    );
-
-    assertEntryEqualsObjectFromAccountObjects(
-      senderKeyPair.publicKey().deriveAddress(),
-      escrowCreate.sequence()
-    );
-
     //////////////////////
     // Wait until the close time on the current validated ledger is after the finishAfter time on the Escrow
     this.scanForResult(
@@ -119,6 +108,12 @@ public void createAndFinishTimeBasedEscrow() throws JsonRpcClientErrorException,
           )
     );
 
+    assertEntryEqualsObjectFromAccountObjects(
+      senderKeyPair.publicKey().deriveAddress(),
+      escrowCreate.sequence()
+    );
+
+
     //////////////////////
     // Receiver submits an EscrowFinish transaction to release the Escrow funds
     AccountInfoResult receiverAccountInfo = this.scanForResult(
@@ -129,7 +124,7 @@ public void createAndFinishTimeBasedEscrow() throws JsonRpcClientErrorException,
       .fee(feeResult.drops().openLedgerFee())
       .sequence(receiverAccountInfo.accountData().sequence())
       .owner(senderKeyPair.publicKey().deriveAddress())
-      .offerSequence(result.transaction().sequence())
+      .offerSequence(createResult.transactionResult().transaction().sequence())
       .signingPublicKey(receiverKeyPair.publicKey())
       .build();
 
@@ -270,8 +265,46 @@ public void createAndFinishTimeBasedEscrowToSelf() throws JsonRpcClientErrorExce
       infoResult -> infoResult.accountData().balance().equals(
         preEscrowFinishSenderAccountInfo.accountData().balance()
           .plus(escrowCreate.amount())
-          .minus(feeResult.drops().openLedgerFee()))
-        && infoResult.accountData().balance().equals(XrpCurrencyAmount.ofDrops(999999980))
+          .minus(feeResult.drops().openLedgerFee())) &&
+        infoResult.accountData().balance().equals(XrpCurrencyAmount.ofDrops(999999980))
+    );
+  }
+
+  @Test
+  public void createEscrowWithInsufficientFunds() throws JsonRpcClientErrorException, JsonProcessingException {
+    //////////////////////
+    // Create random sender accounts
+    KeyPair senderKeyPair = createRandomAccountEd25519();
+
+    //////////////////////
+    // Sender account creates an Escrow with the receiver account
+    FeeResult feeResult = xrplClient.fee();
+    final AccountInfoResult senderAccountInfo = this.scanForResult(
+      () -> this.getValidatedAccountInfo(senderKeyPair.publicKey().deriveAddress())
+    );
+    assertThat(senderAccountInfo.accountData().balance()).isEqualTo(XrpCurrencyAmount.ofDrops(1000000000));
+
+    EscrowCreate escrowCreate = EscrowCreate.builder()
+      .account(senderKeyPair.publicKey().deriveAddress())
+      .sequence(senderAccountInfo.accountData().sequence())
+      .fee(feeResult.drops().openLedgerFee())
+      .amount(XrpCurrencyAmount.ofDrops(1000000001))
+      .destination(senderKeyPair.publicKey().deriveAddress())
+      .cancelAfter(instantToXrpTimestamp(getMinExpirationTime().plus(Duration.ofSeconds(100))))
+      .finishAfter(instantToXrpTimestamp(getMinExpirationTime().plus(Duration.ofSeconds(5))))
+      .signingPublicKey(senderKeyPair.publicKey())
+      .build();
+
+    //////////////////////
+    // Submit the EscrowCreate transaction and validate that it was successful
+    SingleSignedTransaction<EscrowCreate> signedEscrowCreate = signatureService.sign(
+      senderKeyPair.privateKey(), escrowCreate
+    );
+    SubmitResult<EscrowCreate> createResult = xrplClient.submit(signedEscrowCreate);
+    assertThat(createResult.engineResult()).isEqualTo("tecUNFUNDED");
+    logger.info(
+      "EscrowCreate transaction successful: https://testnet.xrpl.org/transactions/{}",
+      createResult.transactionResult().hash()
     );
   }
 
@@ -490,8 +523,8 @@ public void createAndCancelTimeBasedEscrowToSelf() throws JsonRpcClientErrorExce
       infoResult -> infoResult.accountData().balance().equals(
         preEscrowFinishSenderAccountInfo.accountData().balance()
           .plus(escrowCreate.amount())
-          .minus(feeResult.drops().openLedgerFee()))
-        && infoResult.accountData().balance().equals(XrpCurrencyAmount.ofDrops(999999980))
+          .minus(feeResult.drops().openLedgerFee())) &&
+        infoResult.accountData().balance().equals(XrpCurrencyAmount.ofDrops(999999980))
     );
   }
 
@@ -537,17 +570,6 @@ public void createAndFinishCryptoConditionBasedEscrow() throws JsonRpcClientErro
       createResult.transactionResult().hash()
     );
 
-    //////////////////////
-    // Then wait until the transaction gets committed to a validated ledger
-    TransactionResult<EscrowCreate> result = this.scanForResult(
-      () -> this.getValidatedTransaction(createResult.transactionResult().hash(), EscrowCreate.class)
-    );
-
-    assertEntryEqualsObjectFromAccountObjects(
-      senderKeyPair.publicKey().deriveAddress(),
-      escrowCreate.sequence()
-    );
-
     //////////////////////
     // Wait until the close time on the current validated ledger is after the finishAfter time on the Escrow
     this.scanForResult(
@@ -561,6 +583,11 @@ public void createAndFinishCryptoConditionBasedEscrow() throws JsonRpcClientErro
           )
     );
 
+    assertEntryEqualsObjectFromAccountObjects(
+      senderKeyPair.publicKey().deriveAddress(),
+      escrowCreate.sequence()
+    );
+
     //////////////////////
     // Execute the escrow using the secret fulfillment known only to the appropriate party.
     AccountInfoResult receiverAccountInfo = this.scanForResult(
@@ -575,7 +602,7 @@ public void createAndFinishCryptoConditionBasedEscrow() throws JsonRpcClientErro
       .fee(EscrowFinish.computeFee(feeResult.drops().openLedgerFee(), executeEscrowFulfillment))
       .sequence(receiverAccountInfo.accountData().sequence())
       .owner(senderKeyPair.publicKey().deriveAddress())
-      .offerSequence(result.transaction().sequence())
+      .offerSequence(createResult.transactionResult().transaction().sequence())
       .signingPublicKey(receiverKeyPair.publicKey())
       .condition(executeEscrowFulfillment.getDerivedCondition()) // <-- condition and fulfillment are required.
       .fulfillment(executeEscrowFulfillment) // <-- condition and fulfillment are required to finish an escrow