WIP

Author: Patel-Raj11

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/mpt/bulletproofs/EqualityPlaintextProofGenerator.java

@@ -58,11 +58,13 @@ public interface EqualityPlaintextProofGenerator {
    * <p>Callers should simply pass the actual IssuerEncryptedBalance ciphertext and issuer's
    * public key - the swapping is done internally.</p>
    *
+   * <p>The random nonce for the commitment is generated internally using a secure random
+   * number generator, following the same pattern as other proof generators.</p>
+   *
    * @param ciphertext The IssuerEncryptedBalance ciphertext from the MPToken.
    * @param publicKey  The issuer's ElGamal public key.
    * @param amount     The unsigned plaintext amount to clawback.
    * @param randomness The issuer's ElGamal private key (used as "randomness" in the proof).
-   * @param nonceT     The random nonce for the commitment.
    * @param context    The transaction context hash for clawback.
    *
    * @return An {@link EqualityPlaintextProof} (98 bytes: T1 || T2 || s).
@@ -74,7 +76,6 @@ EqualityPlaintextProof generateProof(
     ElGamalPublicKey publicKey,
     UnsignedLong amount,
     BlindingFactor randomness,
-    BlindingFactor nonceT,
     ConfidentialMPTClawbackContext context
   );
 

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/mpt/bulletproofs/java/JavaEqualityPlaintextProofGenerator.java

@@ -37,14 +37,12 @@ public EqualityPlaintextProof generateProof(
     ElGamalPublicKey publicKey,
     UnsignedLong amount,
     BlindingFactor randomness,
-    BlindingFactor nonceT,
     ConfidentialMPTClawbackContext context
   ) {
     Objects.requireNonNull(ciphertext, "ciphertext must not be null");
     Objects.requireNonNull(publicKey, "publicKey must not be null");
     Objects.requireNonNull(amount, "amount must not be null");
     Objects.requireNonNull(randomness, "randomness must not be null");
-    Objects.requireNonNull(nonceT, "nonceT must not be null");
     Objects.requireNonNull(context, "context must not be null");
 
     // Rippled calls secp256k1_equality_plaintext_prove with: (&pk, &c2, &c1, ...)
@@ -55,7 +53,8 @@ public EqualityPlaintextProof generateProof(
     ECPoint c2 = ciphertext.c2();          // balance.c2 stays as c2
     ECPoint pk = ciphertext.c1();          // balance.c1 becomes pk_recipient
 
-    // 1. Use provided nonce t
+    // 1. Generate random nonce t internally (matching C implementation pattern)
+    BlindingFactor nonceT = BlindingFactor.generate();
     BigInteger tInt = new BigInteger(1, nonceT.toBytes());
 
     // 2. Compute commitments T1 = t * G, T2 = t * Pk (where Pk = balance.c1)

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/ConfidentialTransfersIT.java

@@ -982,17 +982,16 @@ public void testEntireFlow() throws JsonRpcClientErrorException, JsonProcessingE
     );
 
     // Generate the Equality Plaintext Proof (parameter swapping handled internally)
+    // The nonce is generated internally by the proof generator
     BlindingFactor issuerPrivateKeyAsBlindingFactor = BlindingFactor.fromBytes(
       issuerElGamalKeyPair.privateKey().naturalBytes().toByteArray()
     );
-    BlindingFactor clawbackNonce = BlindingFactor.generate();
 
     EqualityPlaintextProof clawbackProof = equalityProofGenerator.generateProof(
       issuerBalanceCiphertext,  // IssuerEncryptedBalance ciphertext
       issuerElGamalKeyPair.publicKey(),  // issuer's ElGamal public key
       clawbackAmount,
       issuerPrivateKeyAsBlindingFactor,  // issuer's private key as "randomness"
-      clawbackNonce,  // random nonce for commitment
       clawbackContext
     );