used TransactionType for non_delegable_transactions

Author: cybele-ripple

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java

@@ -55,17 +55,17 @@ public interface DelegateSet extends Transaction {
   /**
    * Set of transaction types that cannot be delegated.
    */
-  Set<String> NON_DELEGABLE_TRANSACTIONS = Sets.newHashSet(
-    TransactionType.ACCOUNT_SET.value(),
-    TransactionType.SET_REGULAR_KEY.value(),
-    TransactionType.SIGNER_LIST_SET.value(),
-    TransactionType.DELEGATE_SET.value(),
-    TransactionType.ACCOUNT_DELETE.value(),
-    TransactionType.BATCH.value(),
+  Set<TransactionType> NON_DELEGABLE_TRANSACTIONS = Sets.newHashSet(
+    TransactionType.ACCOUNT_SET,
+    TransactionType.SET_REGULAR_KEY,
+    TransactionType.SIGNER_LIST_SET,
+    TransactionType.DELEGATE_SET,
+    TransactionType.ACCOUNT_DELETE,
+    TransactionType.BATCH,
     // Pseudo transactions below:
-    TransactionType.ENABLE_AMENDMENT.value(),
-    TransactionType.SET_FEE.value(),
-    TransactionType.UNL_MODIFY.value()
+    TransactionType.ENABLE_AMENDMENT,
+    TransactionType.SET_FEE,
+    TransactionType.UNL_MODIFY
   );
 
   /**
@@ -155,8 +155,10 @@ default void validateNoDuplicatePermissions() {
   default void validateNoNonDelegatableTransactions() {
     for (AccountPermissionWrapper wrapper : permissions()) {
       String permissionValue = wrapper.permission().permissionValue();
+      boolean isNonDelegatable = NON_DELEGABLE_TRANSACTIONS.stream()
+        .anyMatch(txType -> txType.value().equals(permissionValue));
       Preconditions.checkArgument(
-        !NON_DELEGABLE_TRANSACTIONS.contains(permissionValue),
+        !isNonDelegatable,
         String.format("DelegateSet: PermissionValue contains a non-delegatable transaction %s", permissionValue)
       );
     }

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/DelegateSetTest.java

@@ -167,10 +167,10 @@ public void testDelegateSetValidationDuplicatePermissions() {
   @Test
   public void testDelegateSetValidationNonDelegatableTransactions() {
     // Test each non-delegatable transaction type by reusing DelegateSet.NON_DELEGABLE_TRANSACTIONS
-    for (String txType : DelegateSet.NON_DELEGABLE_TRANSACTIONS) {
+    for (TransactionType txType : DelegateSet.NON_DELEGABLE_TRANSACTIONS) {
       List<AccountPermissionWrapper> permissions = Arrays.asList(
         AccountPermissionWrapper.builder()
-          .permission(AccountPermission.builder().permissionValue(txType).build())
+          .permission(AccountPermission.builder().permissionValue(txType.value()).build())
           .build()
       );
 
@@ -371,7 +371,7 @@ public void testAllDelegatableTransactionTypes() {
     // from all TransactionType values. This ensures that when new transaction types are added
     // to the enum, they are automatically tested.
     List<TransactionType> delegatableTypes = Arrays.stream(TransactionType.values())
-      .filter(txType -> !DelegateSet.NON_DELEGABLE_TRANSACTIONS.contains(txType.value()))
+      .filter(txType -> !DelegateSet.NON_DELEGABLE_TRANSACTIONS.contains(txType))
       .filter(txType -> txType != TransactionType.UNKNOWN) // Exclude UNKNOWN
       .collect(Collectors.toList());
 
@@ -403,7 +403,7 @@ public void testAllNonDelegatableTransactionTypesWithEnum() {
     // Automatically derive non-delegatable transaction types from DelegateSet.NON_DELEGABLE_TRANSACTIONS
     // This ensures that when new non-delegatable types are added, they are automatically tested
     List<TransactionType> nonDelegatableTypes = Arrays.stream(TransactionType.values())
-      .filter(txType -> DelegateSet.NON_DELEGABLE_TRANSACTIONS.contains(txType.value()))
+      .filter(txType -> DelegateSet.NON_DELEGABLE_TRANSACTIONS.contains(txType))
       .collect(Collectors.toList());
 
     // Verify we have the expected number of non-delegatable types (sanity check)