Skip to content

Commit f6429e5

Browse files
utafraliclaude
andcommitted
Fix #706: Use SeedCodec.encodeSeed() in Seed.java instead of direct AddressBase58.encode()
Replace direct AddressBase58.encode() calls in ed25519SeedFromEntropy() and secp256k1SeedFromEntropy() with SeedCodec.getInstance().encodeSeed(), centralizing seed encoding logic in SeedCodec to match the existing pattern used for decoding. Remove now-unused imports (AddressBase58, Lists, UnsignedInteger). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 3bda0db commit f6429e5

File tree

1 file changed

+3
-14
lines changed
  • xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/keys

1 file changed

+3
-14
lines changed

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/keys/Seed.java

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,12 @@
2222

2323
import com.google.common.annotations.VisibleForTesting;
2424
import com.google.common.base.Preconditions;
25-
import com.google.common.collect.Lists;
2625
import com.google.common.hash.Hashing;
27-
import com.google.common.primitives.UnsignedInteger;
2826
import org.bouncycastle.asn1.sec.SECNamedCurves;
2927
import org.bouncycastle.asn1.x9.X9ECParameters;
3028
import org.bouncycastle.crypto.params.ECDomainParameters;
3129
import org.bouncycastle.crypto.params.Ed25519PrivateKeyParameters;
3230
import org.bouncycastle.crypto.params.Ed25519PublicKeyParameters;
33-
import org.xrpl.xrpl4j.codec.addresses.AddressBase58;
3431
import org.xrpl.xrpl4j.codec.addresses.Base58;
3532
import org.xrpl.xrpl4j.codec.addresses.Decoded;
3633
import org.xrpl.xrpl4j.codec.addresses.KeyType;
@@ -126,13 +123,9 @@ static Seed ed25519Seed() {
126123
static Seed ed25519SeedFromEntropy(final Entropy entropy) {
127124
Objects.requireNonNull(entropy);
128125

129-
final String base58EncodedSeed = AddressBase58.encode(
130-
entropy.value(),
131-
Lists.newArrayList(Version.ED25519_SEED),
132-
UnsignedInteger.valueOf(entropy.value().length())
133-
);
126+
final String base58EncodedSeed = SeedCodec.getInstance().encodeSeed(entropy.value(), KeyType.ED25519);
134127

135-
return new DefaultSeed(UnsignedByteArray.of(AddressBase58.decode(base58EncodedSeed)));
128+
return new DefaultSeed(UnsignedByteArray.of(Base58.decode(base58EncodedSeed)));
136129
}
137130

138131
/**
@@ -155,11 +148,7 @@ static Seed secp256k1Seed() {
155148
static Seed secp256k1SeedFromEntropy(final Entropy entropy) {
156149
Objects.requireNonNull(entropy);
157150

158-
final String base58EncodedSeed = AddressBase58.encode(
159-
entropy.value(),
160-
Lists.newArrayList(Version.FAMILY_SEED),
161-
UnsignedInteger.valueOf(entropy.value().length())
162-
);
151+
final String base58EncodedSeed = SeedCodec.getInstance().encodeSeed(entropy.value(), KeyType.SECP256K1);
163152

164153
return new DefaultSeed(UnsignedByteArray.of(Base58.decode(base58EncodedSeed)));
165154
}

0 commit comments

Comments
 (0)