From 4e33a2fa24e9aff617679f680fdc2c6a4ff25996 Mon Sep 17 00:00:00 2001 From: Shaun Becker Date: Fri, 10 Oct 2025 15:51:38 -0400 Subject: [PATCH] Migrate HealthChecks.ClickHouse to use official ClickHouse client library --- Directory.Packages.props | 2 +- src/HealthChecks.ClickHouse/ClickHouseHealthCheck.cs | 2 +- .../ClickHouseHealthCheckBuilderExtensions.cs | 2 +- src/HealthChecks.ClickHouse/HealthChecks.ClickHouse.csproj | 2 +- src/HealthChecks.ClickHouse/README.md | 2 +- .../DependencyInjection/RegistrationTests.cs | 2 +- .../Functional/ClickHouseHealthCheckTests.cs | 2 +- .../HealthChecks.ClickHouse.approved.txt | 4 ++-- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 2c2207765a..646303668a 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -24,7 +24,7 @@ - + diff --git a/src/HealthChecks.ClickHouse/ClickHouseHealthCheck.cs b/src/HealthChecks.ClickHouse/ClickHouseHealthCheck.cs index 5dba494c66..15a51e0843 100644 --- a/src/HealthChecks.ClickHouse/ClickHouseHealthCheck.cs +++ b/src/HealthChecks.ClickHouse/ClickHouseHealthCheck.cs @@ -1,4 +1,4 @@ -using ClickHouse.Client.ADO; +using ClickHouse.Driver.ADO; using Microsoft.Extensions.Diagnostics.HealthChecks; namespace HealthChecks.ClickHouse; diff --git a/src/HealthChecks.ClickHouse/DependencyInjection/ClickHouseHealthCheckBuilderExtensions.cs b/src/HealthChecks.ClickHouse/DependencyInjection/ClickHouseHealthCheckBuilderExtensions.cs index 8090c4e0e9..5bc9cee346 100644 --- a/src/HealthChecks.ClickHouse/DependencyInjection/ClickHouseHealthCheckBuilderExtensions.cs +++ b/src/HealthChecks.ClickHouse/DependencyInjection/ClickHouseHealthCheckBuilderExtensions.cs @@ -1,4 +1,4 @@ -using ClickHouse.Client.ADO; +using ClickHouse.Driver.ADO; using HealthChecks.ClickHouse; using Microsoft.Extensions.Diagnostics.HealthChecks; diff --git a/src/HealthChecks.ClickHouse/HealthChecks.ClickHouse.csproj b/src/HealthChecks.ClickHouse/HealthChecks.ClickHouse.csproj index 7036eb3f29..491b612b2a 100644 --- a/src/HealthChecks.ClickHouse/HealthChecks.ClickHouse.csproj +++ b/src/HealthChecks.ClickHouse/HealthChecks.ClickHouse.csproj @@ -9,7 +9,7 @@ - + diff --git a/src/HealthChecks.ClickHouse/README.md b/src/HealthChecks.ClickHouse/README.md index 743c8fccfe..1fc9f9740d 100644 --- a/src/HealthChecks.ClickHouse/README.md +++ b/src/HealthChecks.ClickHouse/README.md @@ -1,6 +1,6 @@ ## ClickHouse Health Check -This health check verifies the ability to communicate with [ClickHouse](https://www.clickhouse.com/). It uses the [ClickHouse.Client](https://www.nuget.org/packages/ClickHouse.Client) library. +This health check verifies the ability to communicate with [ClickHouse](https://www.clickhouse.com/). It uses the official [ClickHouse.Driver](https://www.nuget.org/packages/ClickHouse.Driver) library. ## Recommended approach diff --git a/test/HealthChecks.ClickHouse.Tests/DependencyInjection/RegistrationTests.cs b/test/HealthChecks.ClickHouse.Tests/DependencyInjection/RegistrationTests.cs index 53eb515969..a225cfb038 100644 --- a/test/HealthChecks.ClickHouse.Tests/DependencyInjection/RegistrationTests.cs +++ b/test/HealthChecks.ClickHouse.Tests/DependencyInjection/RegistrationTests.cs @@ -1,4 +1,4 @@ -using ClickHouse.Client.ADO; +using ClickHouse.Driver.ADO; namespace HealthChecks.ClickHouse.Tests.DependencyInjection; diff --git a/test/HealthChecks.ClickHouse.Tests/Functional/ClickHouseHealthCheckTests.cs b/test/HealthChecks.ClickHouse.Tests/Functional/ClickHouseHealthCheckTests.cs index 3cbf9f8552..857fe4a662 100644 --- a/test/HealthChecks.ClickHouse.Tests/Functional/ClickHouseHealthCheckTests.cs +++ b/test/HealthChecks.ClickHouse.Tests/Functional/ClickHouseHealthCheckTests.cs @@ -1,5 +1,5 @@ using System.Net; -using ClickHouse.Client.ADO; +using ClickHouse.Driver.ADO; using Microsoft.Extensions.DependencyInjection.Extensions; using Microsoft.Extensions.Logging; diff --git a/test/HealthChecks.ClickHouse.Tests/HealthChecks.ClickHouse.approved.txt b/test/HealthChecks.ClickHouse.Tests/HealthChecks.ClickHouse.approved.txt index 6863047df1..90130a9059 100644 --- a/test/HealthChecks.ClickHouse.Tests/HealthChecks.ClickHouse.approved.txt +++ b/test/HealthChecks.ClickHouse.Tests/HealthChecks.ClickHouse.approved.txt @@ -2,7 +2,7 @@ namespace HealthChecks.ClickHouse { public class ClickHouseHealthCheck : Microsoft.Extensions.Diagnostics.HealthChecks.IHealthCheck { - public ClickHouseHealthCheck(ClickHouse.Client.ADO.ClickHouseConnection connection, string command) { } + public ClickHouseHealthCheck(ClickHouse.Driver.ADO.ClickHouseConnection connection, string command) { } public System.Threading.Tasks.Task CheckHealthAsync(Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckContext context, System.Threading.CancellationToken cancellationToken = default) { } } } @@ -10,6 +10,6 @@ namespace Microsoft.Extensions.DependencyInjection { public static class ClickHouseHealthCheckBuilderExtensions { - public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddClickHouse(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, System.Func connectionFactory, string healthQuery = "SELECT 1;", string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable? tags = null, System.TimeSpan? timeout = default) { } + public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddClickHouse(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, System.Func connectionFactory, string healthQuery = "SELECT 1;", string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable? tags = null, System.TimeSpan? timeout = default) { } } } \ No newline at end of file