refactor: Improve ordering of headers with clang-format (#5343)

Removes all manual header groupings from source and header files by leveraging clang-format options.

Author: ximinez

.clang-format

@@ -44,6 +44,7 @@ DerivePointerAlignment: false
 DisableFormat:   false
 ExperimentalAutoDetectBinPacking: false
 ForEachMacros:   [ Q_FOREACH,  BOOST_FOREACH ]
+IncludeBlocks:   Regroup
 IncludeCategories:
   - Regex:           '^<(test)/'
     Priority:        0
@@ -53,8 +54,12 @@ IncludeCategories:
     Priority:        2
   - Regex:           '^<(boost)/'
     Priority:        3
-  - Regex:           '.*'
+  - Regex:           '^.*/'
     Priority:        4
+  - Regex:           '^.*\.h'
+    Priority:        5
+  - Regex:           '.*'
+    Priority:        6
 IncludeIsMainRegex: '$'
 IndentCaseLabels: true
 IndentFunctionDeclarationAfterType: false

examples/example/src/example.cpp

@@ -1,7 +1,7 @@
-#include <cstdio>
-
 #include <xrpl/protocol/BuildInfo.h>
 
+#include <cstdio>
+
 int main(int argc, char const** argv) {
     std::printf("%s\n", ripple::BuildInfo::getVersionString().c_str());
     return 0;

hook/hookapi.h

@@ -45,8 +45,8 @@
 
 #include "error.h"
 #include "extern.h"
-#include "sfcodes.h"
 #include "macro.h"
+#include "sfcodes.h"
 #include "tts.h"
 
 #endif

include/xrpl/basics/Log.h

@@ -25,6 +25,7 @@
 
 #include <boost/beast/core/string.hpp>
 #include <boost/filesystem.hpp>
+
 #include <fstream>
 #include <map>
 #include <memory>

include/xrpl/beast/hash/xxhasher.h

@@ -21,6 +21,7 @@
 #define BEAST_HASH_XXHASHER_H_INCLUDED
 
 #include <boost/endian/conversion.hpp>
+
 #include <xxhash.h>
 
 #include <cstddef>

include/xrpl/hook/Guard.h

@@ -1,4 +1,5 @@
 #include "Enum.h"
+
 #include <functional>
 #include <iostream>
 #include <map>

include/xrpl/hook/guard_checker.cpp

@@ -1,15 +1,17 @@
+#include <sys/ioctl.h>
+#include <sys/stat.h>
+
 #include "Guard.h"
 #include <fcntl.h>
-#include <iostream>
-#include <optional>
-#include <ostream>
 #include <stdint.h>
 #include <stdio.h>
 #include <string.h>
-#include <string_view>
-#include <sys/ioctl.h>
-#include <sys/stat.h>
 #include <unistd.h>
+
+#include <iostream>
+#include <optional>
+#include <ostream>
+#include <string_view>
 #include <vector>
 
 int

include/xrpl/protocol/Import.h

@@ -22,9 +22,11 @@
 
 // #include <ripple/basics/Log.h>
 #include <xrpld/app/misc/Manifest.h>
+
 #include <xrpl/basics/StringUtilities.h>
 #include <xrpl/basics/base64.h>
 #include <xrpl/json/json_reader.h>
+
 #include <charconv>
 
 namespace ripple {

include/xrpl/protocol/STLedgerEntry.h

@@ -124,4 +124,4 @@ STLedgerEntry::getType() const
 
 }  // namespace ripple
 
-#endif
+#endif

include/xrpl/server/detail/UDPDoor.h

@@ -25,6 +25,7 @@
 #include <xrpl/server/detail/PlainHTTPPeer.h>
 #include <xrpl/server/detail/SSLHTTPPeer.h>
 #include <xrpl/server/detail/io_list.h>
+
 #include <boost/asio/basic_waitable_timer.hpp>
 #include <boost/asio/buffer.hpp>
 #include <boost/asio/io_context.hpp>
@@ -34,6 +35,7 @@
 #include <boost/beast/core/multi_buffer.hpp>
 #include <boost/beast/core/tcp_stream.hpp>
 #include <boost/container/flat_map.hpp>
+
 #include <chrono>
 #include <condition_variable>
 #include <functional>