[Bug]: Invisible lights not removing after breaking all feral lamps in surrounding area

[NJLively]

Torchmaster Version

21.1.5-beta

Mod Loader

Neoforge

Mod Loader Version

Neoforge 21.1.93

What happened?

I had various feral lamps around my base. I removed them and still some invisible lights persist. I did attempt to use the torchmaster commands, but the dump produces nothing.

Additionally, I used worldedit to try and see if there are any remaining lamps still but it shows 0 total changed.
"//replacenear 100 torchmaster:feral_flare_lantern 0"

Relevant log output

[22:44:34] [Server thread/INFO] [Torchmaster/]: #################################
[22:44:34] [Server thread/INFO] [Torchmaster/]: # Torchmaster Torch Dump Start  #
[22:44:34] [Server thread/INFO] [Torchmaster/]: #################################
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: Torches in dimension minecraft:dimension:
[22:44:34] [Server thread/INFO] [Torchmaster/]: #################################
[22:44:34] [Server thread/INFO] [Torchmaster/]: # Torchmaster Torch Dump End    #
[22:44:34] [Server thread/INFO] [Torchmaster/]: #################################

[NJLively]

Also as a side note, this does persist through server restarts.

[Xalcon]

I will look into the issue tomorrow (2 am here right now). I think I have an idea what's going on, but I need to test it.

In the meantime, the lights that are placed by the lantern are called torchmaster:invisible_light. Could you try replacing those to see if it has an effect?

[Xalcon]

I can't find any issues. The only time this could happen is if the block entity loses its data or if the lantern gets removed improperly. I will need to investigate a few scenarios. In the meantime, I've created a hotfix for MC 1.21.1 to bring back the Frozen Pearl. The version is currently only available on the Github releases https://github.com/Xalcon/TorchMaster/releases/tag/mc1.21.1-21.1.6

[NJLively]

Thank you Xalcon, much appreciated.

I can confirm that replacing the invisible_light block did in fact work in conjunction with worldedit.

I have a theory that at some point these torches were altered or removed all together with worldedit; either directly or indirectly, but the invisible_light was left behind.

Commands such as replace, set, walls, forest and forestgen were used around this time, if that helps.

Thank you again!

[capripio]

This issue can also be occured when using building gadet's cut/paste.

[Xalcon]

Not much that I can do there. The lamp clears all lights it knows about when the block gets removed. Some mods try to remove blocks more efficiently, but that causes the remove block routines to not run, so torch master can't cleanup. I'll bring back the frozen pearl in an update soon for versions that are missing the pearl, but that's everything I can do with the current implementation