Merge pull request #723 from Xian55/backport/4.3.4

Addon: [1.8.0] - Add support Legacy Cataclysm 4.3.4 client

Author: Xian55

.bat/Generate-LuaTextureMapping.ps1

@@ -0,0 +1,55 @@
+param(
+    [Parameter(Mandatory = $true)]
+    [string]$InputCsvPath = "community-listfile.csv",   # https://github.com/wowdev/wow-listfile/releases/latest/download/community-listfile.csv
+    [string]$OutputLuaPath = "LegacyTextureToFileID.lua",
+    [switch]$OnlyIcons = $true                          # keep only interface/icons/*
+)
+
+Write-Host "Reading $InputCsvPath ..."
+$rows = Get-Content -Raw -Path $InputCsvPath -ErrorAction Stop |
+        ConvertFrom-Csv -Delimiter ';' -Header 'FileID','Path'
+
+# Filter: remove .meta and optionally only icons
+$filtered = $rows | Where-Object {
+    $_.Path -and
+    $_.Path -notmatch '\.meta$' -and
+    (-not $OnlyIcons -or $_.Path -match '^interface/icons/')
+}
+
+Write-Host "Found $($filtered.Count) candidate rows."
+
+# Start Lua file
+@(
+    "-- Auto-generated from wowdev community-listfile.csv",
+    "-- Generated: $(Get-Date -Format 'yyyy-MM-dd HH:mm:ss')",
+    "",
+    "DataToColor = DataToColor or {}",
+    "DataToColor.LegacyTextureToFileID = {"
+) | Set-Content -Path $OutputLuaPath -Encoding UTF8
+
+$seen = [System.Collections.Generic.HashSet[string]]::new()
+
+foreach ($row in $filtered) {
+    $fileID = [int]$row.FileID
+    if ($fileID -le 0) { continue }
+
+    # normalize
+    $p = $row.Path.Trim().ToLower()
+    $p = $p -replace '\.blp$', ''
+    $p = $p -replace '/', '\\'
+
+    # only keep ones starting with interface\
+    if ($p -notmatch '^interface\\') { continue }
+
+    # ensure consistent key
+    $key = $p
+
+    # avoid duplicates
+    if ($seen.Add($key)) {
+        $line = '    ["{0}"] = {1},' -f $key, $fileID
+        Add-Content -Path $OutputLuaPath -Value $line -Encoding UTF8
+    }
+}
+
+Add-Content -Path $OutputLuaPath -Value "}" -Encoding UTF8
+Write-Host "✅ Done! Wrote $OutputLuaPath"

.bat/Generate-WorldMapMapping.ps1

@@ -0,0 +1,43 @@
+$luaFile = "UIMapIDToWorldMapAreaID.lua"    # https://www.townlong-yak.com/framexml/8.1.5/Blizzard_Deprecated/UIMapIDToWorldMapAreaID.lua
+$csvFile = "UiMap.8.1.0.27826.csv"          # https://wago.tools/db2/UiMap?build=8.1.0.27826&page=1
+$outFile = "WorldMapAreaIDToUiMapID.lua"
+
+# Build UiMapID → Name lookup (if CSV available)
+$names = @{}
+if (Test-Path $csvFile) {
+    Import-Csv $csvFile | ForEach-Object {
+        if ($_.Name_lang -and $_.ID) {
+            $names[[int]$_.ID] = $_.Name_lang
+        }
+    }
+}
+
+# Parse UiMapID → WorldMapAreaID
+$mapping = @{}
+Select-String -Path $luaFile -Pattern '^\d+,' | ForEach-Object {
+    $cols = $_.Line -split ','
+    if ($cols.Count -ge 2) {
+        $uiMap = [int]$cols[0]
+        $worldMap = [int]$cols[1]
+        if ($uiMap -gt 0 -and $worldMap -gt 0) {
+            if (-not $mapping.ContainsKey($worldMap) -or $uiMap -lt $mapping[$worldMap]) {
+                $mapping[$worldMap] = $uiMap
+            }
+        }
+    }
+}
+
+# Write output
+@(
+    "-- Auto-generated mapping WorldMapAreaID → UiMapID"
+    "DataToColor = DataToColor or {}"
+    "DataToColor.WorldMapAreaIDToUiMapID = {"
+) + ($mapping.GetEnumerator() | Sort-Object Name | ForEach-Object {
+    $comment = ""
+    if ($names.ContainsKey($_.Value)) {
+        $comment = " -- $($names[$_.Value])"
+    }
+    "    [$($_.Name)] = $($_.Value),$comment"
+}) + "}" | Set-Content $outFile -Encoding UTF8
+
+Write-Host "✅ Generated $outFile with $($mapping.Count) entries"

Addons/DataToColor/Collections.lua

@@ -1,35 +1,59 @@
+--[[
+    Collections.lua
+
+    This file provides data structures for managing collections of data over time.
+    It is designed for the DataToColor addon.
+]]
+
 local Load = select(2, ...)
 local DataToColor = unpack(Load)
 
 local GetTime = GetTime
 
+--------------------------------------------------------------------------------
+-- TimedQueue
+-- A queue that releases one item at a time, after a specified tick lifetime.
+-- This is used to iterate over a collection of items across multiple frames.
+--------------------------------------------------------------------------------
 local TimedQueue = {}
 DataToColor.TimedQueue = TimedQueue
 
+-- Constructor for a new TimedQueue
 function TimedQueue:new(tickLifetime, defaultValue)
     local o = {
-        head = {}, tail = {}, index = 1, headLength = 0,
-        tickLifetime = tickLifetime,
-        lastValue = defaultValue,
-        lastChangedTick = 0, defaultValue = defaultValue }
+        head = {},              -- The current batch of items to process
+        tail = {},              -- The next batch of items
+        index = 1,              -- The current position in the head
+        headLength = 0,         -- The number of items in the head
+        tickLifetime = tickLifetime, -- How many ticks an item stays as the current value
+        lastValue = defaultValue, -- The last value shifted from the queue
+        lastChangedTick = 0,    -- The tick when the last value was changed
+        defaultValue = defaultValue -- The value to return when the queue is empty
+    }
     setmetatable(o, self)
     self.__index = self
     return o
 end
 
+-- Shifts an item from the queue if the lifetime has expired.
+-- Otherwise, returns the last shifted item.
 function TimedQueue:shift(globalTick)
+    -- Check if it's time to get a new item
     if math.abs(globalTick - self.lastChangedTick) >= self.tickLifetime or self.lastValue == self.defaultValue then
+        -- If we've processed all items in the head, swap with the tail
         if self.index > self.headLength then
             self.head, self.tail = self.tail, self.head
             self.index = 1
             self.headLength = #self.head
+            -- If the new head is empty, we're done for now
             if self.headLength == 0 then
                 self.lastValue = self.defaultValue
                 return
             end
         end
+
         local value = self.head[self.index]
-        self.head[self.index] = nil
+        self.head[self.index] = nil -- Clear the value from the old table
         self.index = self.index + 1
 
         self.lastValue = value
@@ -41,10 +65,12 @@ function TimedQueue:shift(globalTick)
     return self.lastValue
 end
 
+-- Adds an item to the tail of the queue.
 function TimedQueue:push(item)
     return table.insert(self.tail, item)
 end
 
+-- Peeks at the next item to be shifted without actually shifting it.
 function TimedQueue:peek()
     if self.index <= self.headLength then
         return self.head[self.index]
@@ -55,48 +81,58 @@ function TimedQueue:peek()
     return nil
 end
 
+--------------------------------------------------------------------------------
+-- TimedMap
+-- A map-like structure where entries can be marked as "dirty" and have a
+-- time-based component for retrieval.
+--------------------------------------------------------------------------------
 local struct = {}
-DataToColor.struct = struct
+DataToColor.struct = struct -- Assign to old name for backward compatibility
 
+-- Constructor for a new TimedMap
 function struct:new(tickLifetime)
     local o = {
-        table = {},
+        entries = {},           -- The storage for key-value pairs
         tickLifetime = tickLifetime,
         lastChangedTick = 0,
         lastKey = -1
     }
+    -- For backward compatibility, also provide .table as alias to .entries
+    o.table = o.entries
     setmetatable(o, self)
     self.__index = self
     return o
 end
 
+-- Sets a value for a key.
 function struct:set(key, value)
-    local entry = self.table[key]
+    local entry = self.entries[key]
     if not entry then
-        self.table[key] = { value = value or key, dirty = 0 }
+        self.entries[key] = { value = value or key, dirty = 0 }
         return
     end
 
     entry.value = value or key
     entry.dirty = 0
 end
 
+-- Gets a key-value pair that is not dirty or has expired.
 function struct:getTimed(globalTick)
     local time = GetTime()
-    for k, v in pairs(self.table) do
+    for k, v in pairs(self.entries) do
         if v.dirty == 0 or (v.dirty == 1 and v.value - time <= 0) then
             if self.lastKey ~= k then
                 self.lastKey = k
                 self.lastChangedTick = globalTick
-                --print("changed: ", globalTick, " key:", k, " val: ", v.value)
             end
             return k, v.value
         end
     end
 end
 
+-- Gets a key-value pair, ignoring dirty status.
 function struct:getForced(globalTick)
-    for k, v in pairs(self.table) do
+    for k, v in pairs(self.entries) do
         if self.lastKey ~= v.value then
             self.lastKey = v.value
             self.lastChangedTick = globalTick

Addons/DataToColor/Constants.lua

@@ -37,11 +37,51 @@ DataToColor.C.unitSoftInteract = "softinteract"
 
 DataToColor.C.SpellQueueWindow = "SpellQueueWindow"
 
+DataToColor.C.CHARACTER_CLASS_MAP = {
+    ["None"] = 0,
+    ["Warrior"] = 1,
+    ["Paladin"] = 2,
+    ["Hunter"] = 3,
+    ["Rogue"] = 4,
+    ["Priest"] = 5,
+    ["DeathKnight"] = 6,
+    ["Shaman"] = 7,
+    ["Mage"] = 8,
+    ["Warlock"] = 9,
+    ["Monk"] = 10,
+    ["Druid"] = 11,
+    ["DemonHunter"] = 12
+}
+
+DataToColor.C.CHARACTER_RACE_MAP = {
+    ["None"] = 0,
+    ["Human"] = 1,
+    ["Orc"] = 2,
+    ["Dwarf"] = 3,
+    ["NightElf"] = 4,
+    ["Undead"] = 5,
+    ["Tauren"] = 6,
+    ["Gnome"] = 7,
+    ["Troll"] = 8,
+    ["Goblin"] = 9,
+    ["BloodElf"] = 10,
+    ["Draenei"] = 11,
+    ["Worgen"] = 22
+}
+
 -- Character's name
 DataToColor.C.CHARACTER_NAME = UnitName(DataToColor.C.unitPlayer)
 DataToColor.C.CHARACTER_GUID = UnitGUID(DataToColor.C.unitPlayer)
-_, DataToColor.C.CHARACTER_CLASS, DataToColor.C.CHARACTER_CLASS_ID = UnitClass(DataToColor.C.unitPlayer)
-_, _, DataToColor.C.CHARACTER_RACE_ID = UnitRace(DataToColor.C.unitPlayer)
+DataToColor.C.CHARACTER_CLASS_LOWER, DataToColor.C.CHARACTER_CLASS, DataToColor.C.CHARACTER_CLASS_ID = UnitClass(DataToColor.C.unitPlayer)
+DataToColor.C.CHARACTER_RACE, _, DataToColor.C.CHARACTER_RACE_ID = UnitRace(DataToColor.C.unitPlayer)
+
+if DataToColor.C.CHARACTER_RACE_ID == nil then
+    DataToColor.C.CHARACTER_RACE_ID = DataToColor.C.CHARACTER_RACE_MAP[DataToColor.C.CHARACTER_RACE]
+end
+
+if DataToColor.C.CHARACTER_CLASS_ID == nil then
+    DataToColor.C.CHARACTER_CLASS_ID = DataToColor.C.CHARACTER_CLASS_MAP[DataToColor.C.CHARACTER_CLASS_LOWER]
+end
 
 -- Spells
 DataToColor.C.Spell.AutoShotId = 75