3.3.5 / 4.3.4 backport

[swiftieLoL]

Ive managed to backport the addon to 3.3.5, Ive got 141 pixel rendered at 9 cell size but it cant seem to pick them up.

DataToColor.zip

Some of the log

09:53:02 ResetConfigState

09:53:02 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

09:53:02 Addon Rect(Size [ Width=0, Height=0 ]) size issue. Either too small or too big!

09:53:01 DataFrameMeta { Hash = 4148821, Spacing = 0, Sizes = 41, Rows = 48, Count = 821 }

09:53:00 ResetConfigState

09:53:00 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

09:52:59 Addon Rect(Size [ Width=0, Height=0 ]) size issue. Either too small or too big!

09:52:59 DataFrameMeta { Hash = 4148821, Spacing = 0, Sizes = 41, Rows = 48, Count = 821 }

09:52:57 ResetConfigState

09:52:57 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

09:52:57 ResetConfigState

09:52:57 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

09:52:47 ResetConfigState

09:52:47 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

09:52:47 Frame configuration was incomplete! Please try again, after resolving the previusly mentioned issues...

09:52:47 Addon Rect(Size [ Width=0, Height=0 ]) size issue. Either too small or too big!

09:52:47 DataFrameMeta { Hash = 4148821, Spacing = 0, Sizes = 41, Rows = 48, Count = 821 }

09:52:46 [Enter] press random 51ms

09:52:46 [Enter] press random 53ms

09:52:46 /ert

09:52:45 Enter configuration mode.

09:52:45 Addon installed! Version: 1.7.70

09:52:45 Client window: Rectangle [ X=0, Y=23, Width=1920, Height=1027 ]

09:52:45 Found WowProcess with pid=26760 Wow

09:52:45 ResetConfigState

09:52:45 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

09:49:15 ResetConfigState

09:49:15 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

Any idea?

[Xian55]

Gooday, wow i did not expect to see this one coming. First and foremost thank you for spent the effort of backporting and also big kudos for sharing it! 🙇

---

I try to find a schedule today to look at your work!

---

Are you running the game client in Fullscreen mode? Maybe windowed mode help you out.

[swiftieLoL]

Running it in windowed main monitor:

10:33:48 ResetConfigState

10:33:48 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

10:33:48 Addon Rect(Size [ Width=279, Height=261 ]) size issue. Either too small or too big!

10:33:47 DataFrameMeta { Hash = 729890, Spacing = 0, Sizes = 7, Rows = 29, Count = 890 }

Seems the 890 is way to big?

[Xian55]

Can you tell exactly what version of the game client you are using ?

[swiftieLoL]

3.3.5 but its a server that has a few clientside mods bundled with its custom patches

[Xian55]

3.3.5 but its a server that has a few clientside mods bundled with its custom patches

These custom client patches has to include something similar(this is for vanilla 1.12.1 - https://github.com/luskanek/Interact) in order to even make it viable.

---

What you can try is to dump the state into files (bmp files) and check what the screen grabber can see.

heres a diff what you can apply

diff --git a/Core/WoWScreen/WowScreenDXGI.cs b/Core/WoWScreen/WowScreenDXGI.cs
index a0c0019a..ed5638d1 100644
--- a/Core/WoWScreen/WowScreenDXGI.cs
+++ b/Core/WoWScreen/WowScreenDXGI.cs
@@ -1,4 +1,7 @@
-using Game;
+#define SAVE_ADDON_IMAGE
+#define SAVE_SCREEN_IMAGE
+
+using Game;
 
 using Microsoft.Extensions.Logging;
 
@@ -303,6 +306,10 @@ public sealed class WowScreenDXGI : IWowScreen, IAddonDataProvider
             srcRow.TryCopyTo(destRow);
         }
 
+#if SAVE_ADDON_IMAGE
+        addonImage.SaveAsBmp("addon.bmp");
+#endif
+
     Cleanup:
         device.ImmediateContext.Unmap(addonTexture, 0);
     }
@@ -346,6 +353,10 @@ public sealed class WowScreenDXGI : IWowScreen, IAddonDataProvider
             }
         }
 
+#if SAVE_SCREEN_IMAGE
+        ScreenImage.SaveAsBmp("screen.bmp");
+#endif
+
         device.ImmediateContext.Unmap(screenTexture, 0);
     }

as zip file
WoWScreenDXGI_dump_image.zip

git apply <path_to_the_diff_file>

[swiftieLoL]

3.3.5 had CTM and Interact with target/mouseover as a feature, that can probably navigate around anything but looting. Double pressing the Interact with target key when a mob has loot on it will progress to that corpse and loot it (i believe).

[swiftieLoL]

Image cannot be loaded. Available decoders:

• JPEG : JpegDecoder

SixLabors.ImageSharp.UnknownImageFormatException: Image cannot be loaded. Available decoders:

• JPEG : JpegDecoder

  at SixLabors.ImageSharp.Formats.ImageFormatManager.ThrowInvalidDecoder(ImageFormatManager manager)
  at SixLabors.ImageSharp.Formats.ImageFormatManager.GetEncoder(IImageFormat format)
  at SixLabors.ImageSharp.ImageExtensions.SaveAsBmp(Image source, String path, BmpEncoder encoder)
  at SixLabors.ImageSharp.ImageExtensions.SaveAsBmp(Image source, String path)
  at Core.WowScreenDXGI.UpdateScreenImage(ID3D11Texture2D texture)

Ill change it to JPEG and see if it works.

[swiftieLoL]

This the screen, no addon.JPEG was generated.

[Xian55]

Image cannot be loaded. Available decoders:

Sorry about that, i only checked if the code compiles, i have not checked if it actually runs.

---

#704 (comment)

To me it seems there's a 1px offset from the top of the screen ?

Not so long ago Blizzard made a breaking change regarding how the Widgets are rendered.
a280a8e - https://wowpedia.fandom.com/wiki/BackdropTemplate - https://github.com/Stanzilla/WoWUIBugs/wiki/9.0.1-Consolidated-UI-Changes#backdrop-system-changes
could be related ?

---

if you could tell me the exact RGB color of this cell i could calculate the expected value

Then can cross match with

{ Hash = 729890, Spacing = 0, Sizes = 7, Rows = 29, Count = 890 }

[swiftieLoL]

RGB(166, 86, 116)

[swiftieLoL]

12:07:26 ResetConfigState

12:07:26 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

12:07:26 Frame configuration was incomplete! Please try again, after resolving the previusly mentioned issues...

12:07:26 Addon Rect(Size [ Width=0, Height=0 ]) size issue. Either too small or too big!

12:07:26 DataFrameMeta { Hash = 10901108, Spacing = 1, Sizes = 9, Rows = 1, Count = 108 }

12:07:26 [Enter] press random 42ms

12:07:25 [Enter] press random 67ms

12:07:25 /ert

12:07:25 Enter configuration mode.

12:07:25 Addon installed! Version: 1.7.70

12:07:24 [Enter] press random 52ms

12:07:24 [Enter] press random 48ms

12:07:24 /ert

12:07:23 Enter configuration mode.

12:07:23 Addon installed! Version: 1.7.70

12:07:23 Client window: Rectangle [ X=1, Y=27, Width=1394, Height=784 ]

12:07:23 Found WowProcess with pid=7120 Wow

12:07:23 ResetConfigState

12:07:23 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

12:07:17 WowScreenDXGI

Resolved the border issue and it seems it now is finding the correct 108 frames

[Xian55]

For RGB(166, 86, 116) the calculation proceeds as follows:

• hash = 166 × 65 536 + 86 × 256 + 116 = 10 901108.
• spacing = hash / 10 000 000 = 1.
• size = (hash / 100 000) % 100 = 9.
• rows = (hash / 1 000) % 100 = 1.
• count = hash % 1 000 = 108.

So a pixel with colour (R = 166, G = 86, B = 116) would yield a DataFrameMeta with
Hash = 10901108, Spacing = 1, Sizes = 9, Rows = 1 and Count = 108

Currently 108 is the total cell count, that's correct.

[Xian55]

12:07:26 ResetConfigState

12:07:26 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

12:07:26 Frame configuration was incomplete! Please try again, after resolving the previusly mentioned issues...

12:07:26 Addon Rect(Size [ Width=0, Height=0 ]) size issue. Either too small or too big!

12:07:26 DataFrameMeta { Hash = 10901108, Spacing = 1, Sizes = 9, Rows = 1, Count = 108 }

12:07:26 [Enter] press random 42ms

12:07:25 [Enter] press random 67ms

12:07:25 /ert

12:07:25 Enter configuration mode.

12:07:25 Addon installed! Version: 1.7.70

12:07:24 [Enter] press random 52ms

12:07:24 [Enter] press random 48ms

12:07:24 /ert

12:07:23 Enter configuration mode.

12:07:23 Addon installed! Version: 1.7.70

12:07:23 Client window: Rectangle [ X=1, Y=27, Width=1394, Height=784 ]

12:07:23 Found WowProcess with pid=7120 Wow

12:07:23 ResetConfigState

12:07:23 DataFrames 0 - Texture: Size [ Width=1, Height=1 ]

12:07:17 WowScreenDXGI

Resolved the border issue and it seems it now is finding the correct 108 frames

If you could share, what you changed, i might be able to incorporate during the calculation.

[swiftieLoL]

in line 1046 in DataToColor.Lua (the one i uploaded) i changed the genFrame function to this:
local function genFrame(name, x, y)
local f = CreateFrame("Frame", name, UIParent)
ert:Print("Frames")

    local xx = x * floor(CELL_SIZE + CELL_SPACING)
    local yy = floor(-y * (CELL_SIZE + CELL_SPACING))
    --ert:Print(name, " ", xx, " ", yy)

    f:SetPoint("TOPLEFT", xx - 1, yy +2 )
    f:SetHeight(CELL_SIZE)
    f:SetWidth(CELL_SIZE)
    f:SetBackdrop({
        bgFile = "Interface\\AddOns\\ert\\white.tga",
        insets = { top = 0, left = 0, bottom = 0, right = 0 },
    })
    f:SetFrameStrata("TOOLTIP")
    f:SetBackdropColor(0, 0, 0, 1)
    return f
end

to offset by the gap

The only line change was
f:SetPoint("TOPLEFT", xx - 1, yy +2 )
from

f:SetPoint("TOPLEFT", xx , yy )