Skip to content

Commit 0400559

Browse files
author
dkorolij
committed
HLS dynamic MVAU tests passing.
- Changed the datatype for the HLS test case, from [UINT8, INT8] to [INT8, INT8]. Seems the core was not handling mixed datatypes. - Update to the RTL dynamic_load core (bug fix).
1 parent c87bc62 commit 0400559

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

finn-rtllib/dynload/hdl/dynamic_load.sv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,14 +237,14 @@ always_comb begin : NSL_PROC_RD
237237

238238
case (state_rd_C)
239239
ST_RD_0:
240-
if(ordy && (state_wr_C == ST_WR_0) ? (curr_sf_C > cons_sfnf_C) : 1'b1) begin
240+
if(ordy && ((state_wr_C == ST_WR_0) ? (curr_sf_C > cons_sfnf_C) : 1'b1)) begin
241241
if((cons_sfnf_C == N_TLS-1) && (cons_r_C == N_REPS-1)) begin
242242
state_rd_N = ST_RD_1;
243243
end
244244
end
245245

246246
ST_RD_1:
247-
if(ordy && (state_wr_C == ST_WR_1) ? (curr_sf_C > cons_sfnf_C) : 1'b1) begin
247+
if(ordy && ((state_wr_C == ST_WR_1) ? (curr_sf_C > cons_sfnf_C) : 1'b1)) begin
248248
if((cons_sfnf_C == N_TLS-1) && (cons_r_C == N_REPS-1)) begin
249249
state_rd_N = ST_RD_0;
250250
end

tests/fpgadataflow/test_fpgadataflow_mvau.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,7 @@ def test_fpgadataflow_rtl_mvau(
847847
@pytest.mark.parametrize("n_vectors", [128])
848848
@pytest.mark.parametrize("pe", [32])
849849
@pytest.mark.parametrize("simd", [16])
850-
@pytest.mark.parametrize("idt_wdt", [[DataType["UINT8"], DataType["INT8"]]])
850+
@pytest.mark.parametrize("idt_wdt", [[DataType["INT8"], DataType["INT8"]]])
851851
@pytest.mark.parametrize("part", ["xcvc1902-vsva2197-2MP-e-S"])
852852
@pytest.mark.parametrize("clk_ns", [4])
853853
@pytest.mark.parametrize("pumpedCompute", [False])

0 commit comments

Comments
 (0)