Skip to content

Commit c8be504

Browse files
author
Yaman Umuroglu
authored
Merge pull request #346 from quetric/res_est_fix
Fix resource estimate for external weights FC layer
2 parents b3da380 + cdb2f91 commit c8be504

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

docker/finn_entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ recho () {
1818
# checkout the correct dependency repo commits
1919
# the repos themselves are cloned in the Dockerfile
2020
FINN_BASE_COMMIT=ac0b86a63eb937b869bfa453a996a8a8b8506546
21-
FINN_EXP_COMMIT=e9f97dcdb4db2f889b0f36af079a6a1792b7d4de
21+
FINN_EXP_COMMIT=f82c0d9868bb88ea045dfadb28508d327d287221
2222
BREVITAS_COMMIT=d7ded80fa9557da2998ea310669edee7fb2d9526
2323
CNPY_COMMIT=4e8810b1a8637695171ed346ce68f6984e585ef4
2424
HLSLIB_COMMIT=4d74baefa79df48b5a0348d63f39a26df075de51

src/finn/custom_op/fpgadataflow/streamingfclayer_batch.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,8 @@ def uram_estimation(self):
239239
mmode = self.get_nodeattr("mem_mode")
240240
mstyle = self.get_nodeattr("ram_style")
241241
if (mmode == "decoupled" and mstyle != "ultra") or (
242-
mmode == "const" and self.calc_wmem() <= 128
242+
mmode == "const" and self.calc_wmem() <= 128) or (
243+
mmode == "external"
243244
):
244245
return 0
245246
width_multiplier = math.ceil(mem_width / 72)
@@ -266,7 +267,8 @@ def bram_estimation(self):
266267
mmode = self.get_nodeattr("mem_mode")
267268
mstyle = self.get_nodeattr("ram_style")
268269
if (mmode == "decoupled" and mstyle in ["distributed", "ultra"]) or (
269-
mmode == "const" and self.calc_wmem() <= 128
270+
mmode == "const" and self.calc_wmem() <= 128) or (
271+
mmode == "external"
270272
):
271273
return 0
272274
# assuming SDP mode RAMB18s (see UG573 Table 1-10)

0 commit comments

Comments
 (0)