fixed the test failures. All 59 tests are now passing. I've updated DocumentationService to handle file paths and read errors more robustly

Author: Xoshbin

src/Services/DocumentationService.php

@@ -217,7 +217,9 @@ public function get(string $locale, string $slug): array
         }
 
         $mtime = File::lastModified($path);
-        $cacheKey = 'pertuk:docs:'.$locale.':'.md5($path.':'.$mtime);
+        // Use realpath to ensure consistent cache keys regardless of symlinks/relative paths
+        $realPath = realpath($path) ?: $path;
+        $cacheKey = 'pertuk:docs:'.$locale.':'.md5($realPath.':'.$mtime);
 
         // Get cached value and validate it
         $cached = Cache::get($cacheKey);
@@ -247,6 +249,11 @@ private function isValidCachedDocument(mixed $data): bool
     private function generateDocumentData(string $path, string $locale, string $slug, int $mtime): array
     {
         $raw = File::get($path);
+
+        if ($raw === false) {
+            throw new \RuntimeException("Failed to read file: {$path}");
+        }
+
         try {
             $front = YamlFrontMatter::parse($raw);
             $content = $front->body();

tests/Feature/CacheTest.php

@@ -29,7 +29,8 @@
     // Verify cache key exists
     $path = $this->getTestDocsPath().'/en/test-cache.md';
     $mtime = File::lastModified($path);
-    $cacheKey = 'pertuk:docs:en:'.md5($path.':'.$mtime);
+    $realPath = realpath($path) ?: $path;
+    $cacheKey = 'pertuk:docs:en:'.md5($realPath.':'.$mtime);
 
     expect(Cache::has($cacheKey))->toBeTrue();
 });
@@ -75,7 +76,8 @@
     // Verify it's cached
     $path = $this->getTestDocsPath().'/en/test-ttl.md';
     $mtime = File::lastModified($path);
-    $cacheKey = 'pertuk:docs:en:'.md5($path.':'.$mtime);
+    $realPath = realpath($path) ?: $path;
+    $cacheKey = 'pertuk:docs:en:'.md5($realPath.':'.$mtime);
     expect(Cache::has($cacheKey))->toBeTrue();
 
     // Wait for TTL to expire
@@ -102,8 +104,11 @@
     $mtime1 = File::lastModified($path1);
     $mtime2 = File::lastModified($path2);
 
-    $cacheKey1 = 'pertuk:docs:en:'.md5($path1.':'.$mtime1);
-    $cacheKey2 = 'pertuk:docs:en:'.md5($path2.':'.$mtime2);
+    $realPath1 = realpath($path1) ?: $path1;
+    $realPath2 = realpath($path2) ?: $path2;
+
+    $cacheKey1 = 'pertuk:docs:en:'.md5($realPath1.':'.$mtime1);
+    $cacheKey2 = 'pertuk:docs:en:'.md5($realPath2.':'.$mtime2);
 
     expect($cacheKey1)->not->toBe($cacheKey2);
     expect(Cache::has($cacheKey1))->toBeTrue();
@@ -146,7 +151,8 @@
     // Manually corrupt the cache
     $path = $this->getTestDocsPath().'/en/cache-corruption.md';
     $mtime = File::lastModified($path);
-    $cacheKey = 'pertuk:docs:en:'.md5($path.':'.$mtime);
+    $realPath = realpath($path) ?: $path;
+    $cacheKey = 'pertuk:docs:en:'.md5($realPath.':'.$mtime);
 
     Cache::put($cacheKey, 'corrupted-data', 60);