Skip to content

Commit d30488d

Browse files
🐛 fix: Add null checks for alert entity access to prevent crashes
1 parent 4855b3a commit d30488d

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

api/v1/alert.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,9 @@ async def alert_me_verification(verification_token: str, request: Request):
161161
with datastore_client.transaction():
162162
# Fetch inside transaction to ensure we have current data
163163
alert_task = datastore_client.get(alert_key)
164-
if alert_task["verified"]:
164+
if not alert_task:
165+
raise HTTPException(status_code=404, detail="Not found")
166+
if alert_task.get("verified"):
165167
alert_task["recent_timestamp"] = datetime.now()
166168
alert_task["token"] = verification_token
167169
else:
@@ -232,7 +234,10 @@ async def send_verification(
232234
alert_key = datastore_client.key("xon_alert", user_email)
233235
alert_task = datastore_client.get(alert_key)
234236

235-
if alert_task["verified"] and alert_task["token"] == token:
237+
if not alert_task:
238+
return VerificationResponse(status="Failed")
239+
240+
if alert_task.get("verified") and alert_task.get("token") == token:
236241
now = datetime.now()
237242
verification_timestamp = alert_task["verify_timestamp"]
238243

0 commit comments

Comments
 (0)