Merge pull request #299 from XpressAI/paul/await-all

MFA-X-AI · web-flow · commit c01a73c64851 · 2024-02-22T22:47:14.000+08:00
Await both context.ready and content.renderPromise before saving
diff --git a/src/index.tsx b/src/index.tsx
@@ -175,7 +175,7 @@ const xircuits: JupyterFrontEndPlugin<void> = {
             factory: FACTORY
           }
         );
-        await newWidget.content.renderPromise;
+        await Promise.all([newWidget.context.ready, newWidget.content.renderPromise]);
         await app.commands.execute(commandIDs.saveXircuit, {
             path: model.path
         });

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ const xircuits: JupyterFrontEndPlugin<void> = {`
`175`	`175`	`factory: FACTORY`
`176`	`176`	`}`
`177`	`177`	`);`
`178`		`- await newWidget.content.renderPromise;`
	`178`	`+ await Promise.all([newWidget.context.ready, newWidget.content.renderPromise]);`
`179`	`179`	`await app.commands.execute(commandIDs.saveXircuit, {`
`180`	`180`	`path: model.path`
`181`	`181`	`});`