Merge pull request #116 from Xvezda/feature/handle-constructor-exceptions

feature/handle constructor exceptions

Author: Xvezda

package.json

@@ -37,6 +37,7 @@
   "license": "MIT",
   "packageManager": "[email protected]",
   "devDependencies": {
+    "@typescript/lib-es5": "npm:@types-with-exceptions/[email protected]",
     "@types-with-exceptions/node": "22.15.29-dev.0",
     "@typescript-eslint/parser": "^8.32.1",
     "@typescript-eslint/rule-tester": "^8.32.1",

pnpm-lock.yaml

@@ -658,8 +658,9 @@ module.exports = createRule({
         throwStatementNodes.push(node);
         metadata.set(node, { pos: node.range[0] });
       },
-      ':function MemberExpression[property.type="Identifier"]': visitFunctionCallNode,
+      ':function NewExpression[callee.type="Identifier"]': visitFunctionCallNode,
       ':function CallExpression[callee.type="Identifier"]': visitFunctionCallNode,
+      ':function MemberExpression[property.type="Identifier"]': visitFunctionCallNode,
       ':function AssignmentExpression[left.type="MemberExpression"]': visitFunctionCallNode,
 
       /**

src/rules/check-throws-tag-type.js

@@ -540,6 +540,7 @@ module.exports = createRule({
 
         throwStatementNodes.push(node);
       },
+      ':function NewExpression[callee.type="Identifier"]': visitFunctionCallNode,
       ':function CallExpression[callee.type="Identifier"]': visitFunctionCallNode,
       ':function MemberExpression[property.type="Identifier"]': visitFunctionCallNode,
       ':function AssignmentExpression[left.type="MemberExpression"]': visitFunctionCallNode,

src/rules/no-undocumented-throws.js

@@ -281,6 +281,7 @@ const getCallSignatureDeclaration = (services, node) => {
  */
 const getCallee = (node) => {
   switch (node.type) {
+    case AST_NODE_TYPES.NewExpression:
     case AST_NODE_TYPES.CallExpression:
       return node.callee;
     // Setter
@@ -310,6 +311,7 @@ const getCalleeDeclaration = (services, node) => {
   /** @type {import('typescript').Declaration | null} */
   let declaration = null;
   if (
+    node.type === AST_NODE_TYPES.NewExpression ||
     node.type === AST_NODE_TYPES.CallExpression ||
     node.type === AST_NODE_TYPES.MemberExpression &&
     node.parent?.type === AST_NODE_TYPES.CallExpression
@@ -390,6 +392,7 @@ const getCalleeDeclaration = (services, node) => {
       }
       return null;
     }
+    case AST_NODE_TYPES.NewExpression:
     case AST_NODE_TYPES.CallExpression:
       return declaration;
     default:

src/utils.js

@@ -969,6 +969,27 @@ ruleTester.run(
           { messageId: 'throwTypeMismatch' },
         ],
       },
+      {
+        code: `
+          /**
+           * @param {number} value
+           * @throws {TypeError}
+           */
+          function foo(value) {
+            new ArrayBuffer(value);
+          }
+        `,
+        output: `
+          /**
+           * @param {number} value
+           * @throws {RangeError}
+           */
+          function foo(value) {
+            new ArrayBuffer(value);
+          }
+        `,
+        errors: [{ messageId: 'throwTypeMismatch' }],
+      },
     ],
   },
 );

tests/rules/check-throws-tag-type.test.js

@@ -2793,6 +2793,26 @@ ruleTester.run(
         `,
         errors: [{ messageId: 'missingThrowsTag' }],
       },
+      {
+        code: `
+          /**
+           * @param {number} value
+           */
+          function foo(value) {
+            new ArrayBuffer(value);
+          }
+        `,
+        output: `
+          /**
+           * @param {number} value
+           * @throws {RangeError}
+           */
+          function foo(value) {
+            new ArrayBuffer(value);
+          }
+        `,
+        errors: [{ messageId: 'missingThrowsTag' }],
+      },
     ],
   },
 );

tests/rules/no-undocumented-throws.test.js

@@ -13,7 +13,7 @@
 
     /* Language and Environment */
     "target": "es2018",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
-    "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
+    "lib": ["es5"],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     "libReplacement": true,                           /* Enable lib replacement. */
     // "experimentalDecorators": true,                   /* Enable experimental support for legacy experimental decorators. */