Skip to content

Commit 18729f0

Browse files
authored
Merge pull request #206 from YAPP-Github/refactor/#205-dynamic-versionname-fetch
[REFACTOR] versionName을 하드코딩된 값에서 동적으로 가져오는 방식으로 변경
2 parents 6705e60 + d39a43e commit 18729f0

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

feature/setting/src/main/java/com/yapp/setting/SettingScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ private fun SettingContent(
184184
.padding(horizontal = 24.dp),
185185
)
186186
Spacer(modifier = Modifier.weight(1f))
187-
VersionCodeText(versionCode = "v1.0.0")
187+
VersionCodeText()
188188
Spacer(modifier = Modifier.height(24.dp))
189189
}
190190
}

feature/setting/src/main/java/com/yapp/setting/component/VersionCodeText.kt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,25 @@
11
package com.yapp.setting.component
22

3+
import android.content.pm.PackageManager
34
import androidx.compose.foundation.layout.fillMaxWidth
45
import androidx.compose.material3.Text
56
import androidx.compose.runtime.Composable
67
import androidx.compose.ui.Modifier
8+
import androidx.compose.ui.platform.LocalContext
79
import androidx.compose.ui.text.style.TextAlign
810
import com.yapp.designsystem.theme.OrbitTheme
911

1012
@Composable
11-
fun VersionCodeText(versionCode: String) {
13+
fun VersionCodeText() {
14+
val context = LocalContext.current
15+
val versionName = try {
16+
context.packageManager.getPackageInfo(context.packageName, 0).versionName
17+
} catch (e: PackageManager.NameNotFoundException) {
18+
"1.0.0"
19+
}
20+
1221
Text(
13-
text = versionCode,
22+
text = "v$versionName",
1423
modifier = Modifier.fillMaxWidth(),
1524
style = OrbitTheme.typography.body1Regular,
1625
color = OrbitTheme.colors.gray_300,

0 commit comments

Comments
 (0)