Skip to content

Does not compile in CMake 4 #580

Description

@Reycko

This project won't compile in CMake 4, this isn't too big of an issue but future proofing for CMake 4 in advance could serve a good purpose.

However, this would require changes to some dependencies:

  • hltas: Renamed custom Rust language support to something else to coexist with CMake 4
  • discord-rpc: Use a rapidjson commit past Tencent/rapidjson@862c39b, update cmake_minimum_required to 3.10
  • hlstrafe: Change cmake_minimum_required to 3.10
  • taslogger: Change cmake_minimum_required to 3.10

Cotire would also need to be removed, replaced, or patched as well as it has been archived since long enough for it to be meant for CMake 2.8.

I have a fork of this project that contains patches and tweaks to compile on CMake 4, looking at the patch files from there should show what to change externally. I decided to replace cotire with CMake 3.16+ options in my case. I won't send my fork as a PR since it overuses patches and it's way too hacky to patch 3 packages at once. I could do a PR if someone wants it, but I won't do it yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions