Skip to content

Commit 5f24107

Browse files
authored
Merge pull request #844 from Yacht-sh/develop
Develop
2 parents 4ee8231 + ddaf3d8 commit 5f24107

5 files changed

Lines changed: 45 additions & 44 deletions

File tree

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
---
2-
version: "3"
31
services:
42
yacht:
53
container_name: yacht
@@ -9,7 +7,7 @@ services:
97
volumes:
108
- yacht:/config
119
- /var/run/docker.sock:/var/run/docker.sock
12-
image: yacht-sh/yacht:main
10+
image: ghcr.io/yacht-sh/yacht:latest
1311

1412
volumes:
1513
yacht:

Docker-Compose-Files/docker-compose-MAC-Linux.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
version: '3'
21
services:
32
yacht:
43
container_name: yacht
@@ -13,6 +12,6 @@ services:
1312
- PUID=0
1413
- PGID=0
1514
- COMPOSE_DIR=/compose
16-
image: yacht-sh/yacht:main
15+
image: ghcr.io/yacht-sh/yacht:latest
1716
volumes:
1817
yacht:

Docker-Compose-Files/docker-compose-w-traefik.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
1-
### Use are your own risk, has not been tested by staff.
2-
3-
---
4-
version: "3"
1+
### Example only. Validate labels, entrypoints, and certificate resolver values for your Traefik setup.
52

63
networks:
74
traefik_network:
8-
external:
9-
name: web
5+
name: web
6+
external: true
107

118
services:
129
yacht:
13-
image: yacht-sh/yacht:main
10+
image: ghcr.io/yacht-sh/yacht:latest
1411
restart: unless-stopped
1512
networks:
1613
- traefik_network
@@ -35,4 +32,4 @@ services:
3532
- "traefik.http.routers.yacht.tls=true"
3633
- "traefik.http.routers.yacht.tls.certresolver=dns"
3734
- "traefik.http.routers.yacht.tls.domains[0].main=domain.tld"
38-
- "traefik.http.routers.yacht.tls.domains[0].sans=*.domain.tld"
35+
- "traefik.http.routers.yacht.tls.domains[0].sans=*.domain.tld"

docs/ci-cd.md

Lines changed: 16 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,21 @@ Agent image:
1212

1313
- `ghcr.io/<owner>/yacht-agent`
1414

15-
## Branch Workflows
15+
## Workflow
1616

17-
### Develop
17+
Current image publishing uses:
1818

19-
Workflow:
20-
21-
- `.github/workflows/docker-image.yml`
19+
- `.github/workflows/build.yml`
2220

2321
Trigger:
2422

2523
- push to `develop`
24+
- push to `master`
2625
- manual dispatch
2726

28-
Verification stages:
27+
## Verification Stages
28+
29+
Before publishing, the workflow verifies:
2930

3031
- frontend install
3132
- frontend lint
@@ -40,39 +41,22 @@ Verification stages:
4041
- agent Bandit scan
4142
- agent pip-audit
4243

43-
Publish stages:
44+
## Publish Tags
45+
46+
On `develop`:
4447

4548
- `yacht:dev-latest`
46-
- `yacht:<YYYYMMDD-HHMMSS>`
49+
- `yacht:dev-<YYYYMMDD-HHMMSS>`
4750
- `yacht-agent:dev-latest`
48-
- `yacht-agent:<YYYYMMDD-HHMMSS>`
49-
50-
### Master
51-
52-
Workflow:
53-
54-
- `.github/workflows/build.yml`
55-
56-
Trigger:
57-
58-
- push to `master`
59-
- manual dispatch
51+
- `yacht-agent:dev-<YYYYMMDD-HHMMSS>`
6052

61-
Publish stages:
53+
On `master`:
6254

6355
- `yacht:latest`
6456
- `yacht:<YYYYMMDD-HHMMSS>`
6557
- `yacht-agent:latest`
6658
- `yacht-agent:<YYYYMMDD-HHMMSS>`
6759

68-
## Manual Builds
69-
70-
Workflow:
71-
72-
- `.github/workflows/manual-build.yml`
73-
74-
This workflow can build either image from a provided ref or tag and publish it to GHCR.
75-
7660
## Supply Chain Metadata
7761

7862
Current Docker build jobs enable:
@@ -82,8 +66,9 @@ Current Docker build jobs enable:
8266

8367
## Authentication
8468

85-
The workflows publish with:
69+
The workflows log in to GHCR with:
8670

87-
- `GITHUB_TOKEN`
71+
- `GHCR_USERNAME` and `GHCR_TOKEN` when provided
72+
- otherwise `github.actor` and `GITHUB_TOKEN`
8873

8974
There is no Docker Hub publishing path in the current repo configuration.

docs/installation.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,25 @@ The repo also includes additional compose examples under:
8888
- `Docker-Compose-Files/docker-compose-w-traefik.yml`
8989

9090
Review those files before use. They are examples, not guarantees of current production readiness.
91+
92+
## Traefik Compose Notes
93+
94+
The current Traefik example assumes:
95+
96+
- image: `ghcr.io/yacht-sh/yacht:latest`
97+
- internal Yacht service port: `8000`
98+
- reverse proxy target protocol: `http`
99+
- external Traefik Docker network named `web`
100+
101+
Why port `8000` is correct:
102+
103+
- the container starts FastAPI behind the bundled `nginx.conf`
104+
- nginx listens on `8000` inside the container
105+
- Traefik should route to that internal nginx listener, not directly to uvicorn
106+
107+
Before using the example, replace:
108+
109+
- `yacht.domain.tld`
110+
- `domain.tld`
111+
- `dns` certificate resolver name
112+
- `./config` if you want a different persistent config path

0 commit comments

Comments
 (0)