Skip to content

Commit e3b585d

Browse files
committed
Refactor libv8 unzip steps in CI workflows for improved clarity and consistency
1 parent d58228c commit e3b585d

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

.github/workflows/leakcheck.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,11 @@ jobs:
2222

2323
- name: Unzip libv8
2424
run: |
25-
files=$(find . -name "libv8.a.zip")
25+
files=$(find . -name "libv8*.zip")
2626
for file in $files; do
27-
unzip -o -d $(dirname $file) $file
27+
dir=$(dirname "$file") # Get the directory where the ZIP file is located
28+
echo "Extracting $file to directory $dir"
29+
unzip -o -d $dir $file
2830
done
2931
3032
- name: Go Test

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ jobs:
2727

2828
- name: Unzip libv8
2929
run: |
30-
files=$(find . -name "libv8-*.zip")
30+
files=$(find . -name "libv8*.zip")
3131
for file in $files; do
32-
unzip -o -d $(dirname $file) $file
32+
dir=$(dirname "$file") # Get the directory where the ZIP file is located
33+
echo "Extracting $file to directory $dir"
34+
unzip -o -d $dir $file
3335
done
3436
3537
- name: Go Test

.github/workflows/v8build.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,18 @@ jobs:
2121
- name: Checkout
2222
uses: actions/checkout@v4
2323
with:
24-
lfs: true
2524
submodules: true
2625
fetch-depth: 1
2726

27+
- name: Unzip libv8
28+
run: |
29+
files=$(find . -name "libv8*.zip")
30+
for file in $files; do
31+
dir=$(dirname "$file") # Get the directory where the ZIP file is located
32+
echo "Extracting $file to directory $dir"
33+
unzip -o -d $dir $file
34+
done
35+
2836
- name: Update depot_tools fetch config
2937
run: cd deps/depot_tools && git config --unset-all remote.origin.fetch; git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/*
3038
shell: bash

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,5 @@ deps/.gclient_previous*
1010
c.out
1111
.idea/*
1212
/v8go.test
13+
deps/*/libv8.a
14+
deps/*/__MACOSX

0 commit comments

Comments
 (0)