phase-6: filter benign stderr noise so successful builds don't show errorsCount=1

STATIC_MODE_REMAINING freestyle-sh#6 — vite v5.x prints "The CJS build of Vite's Node
API is deprecated..." to stderr on every successful build, npm/Browserslist
similarly leak warn/notice lines. The fallback "unknown" branch in
parseBuildErrors fired on these, producing audit log entries like:

  {"event":"build_finished","status":"succeeded","exitCode":0,
   "durationMs":8338,"errorsCount":1}

Fix: BENIGN_STDERR_LINE_PATTERNS — narrow line-level regexes for the
specific known noise. stripBenignStderr() helper applies them; the
fallback now decides on the post-strip stderr instead of the raw one.
Patterns kept narrow on purpose: too-loose hides real errors, and any
stderr that consists *entirely* of these is a genuinely-successful build.

5 new tests cover the regression: banner-only, full Vite v5.4.21 success
output, npm warn/notice/info, Browserslist nag, real error mixed with
banner. 565/22 stable.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Adorable Fork Bot

adorable/lib/preview/build-error-parser.ts

@@ -28,6 +28,39 @@ export interface ParseInput {
   boilerplateVersion?: string;
 }
 
+// Vite/npm/Node emit these to stderr on every successful build. The
+// fallback "unknown error" branch was firing on them, producing
+// errorsCount=1 with status=succeeded. Strip them before deciding
+// whether stderr contains anything actionable.
+//
+// Each pattern is matched against a single stderr line. Order doesn't
+// matter — we check `some(line)` per line. Keep the patterns NARROW:
+// a too-loose pattern hides real errors. If a real failure ever has a
+// stderr that consists *entirely* of these benign lines, that's a
+// pathological case the executor's exitCode != 0 still flags.
+const BENIGN_STDERR_LINE_PATTERNS: readonly RegExp[] = [
+  // Vite v5.x CJS API deprecation banner.
+  /^\s*The CJS build of Vite's Node API is deprecated\b/,
+  /^\s*See https:\/\/vite\.dev\/guide\/troubleshooting\.html#vite-cjs-node-api-deprecated\b/,
+  // npm informational lines that occasionally leak to stderr.
+  /^\s*npm\s+(?:warn|notice|info)\b/i,
+  // Browserslist nag (vite/postcss runs it).
+  /^\s*Browserslist:\s+caniuse-lite is outdated\b/,
+  /^\s*Please run:\s*npx update-browserslist-db@latest\b/,
+  // Empty / blank lines.
+  /^\s*$/,
+];
+
+const isBenignStderrLine = (line: string): boolean =>
+  BENIGN_STDERR_LINE_PATTERNS.some((re) => re.test(line));
+
+// Exposed so callers can audit the stripper independently.
+export const stripBenignStderr = (stderr: string): string =>
+  stderr
+    .split("\n")
+    .filter((line) => !isBenignStderrLine(line))
+    .join("\n");
+
 // ---------------------------------------------------------------------------
 // parseBuildErrors
 // ---------------------------------------------------------------------------
@@ -141,14 +174,20 @@ export const parseBuildErrors = (input: ParseInput): BuildError[] => {
     });
   }
 
-  // 5. Если вообще ничего не распарсили, но stderr непустой — эмитим
-  // generic {code:"unknown", message: head(stderr)}.
-  if (errors.length === 0 && (input.stderr ?? "").trim()) {
-    push({
-      code: "unknown",
-      message: input.stderr.slice(0, UNKNOWN_HEAD_BYTES).trim(),
-      raw: input.stderr.slice(0, UNKNOWN_HEAD_BYTES),
-    });
+  // 5. Если вообще ничего не распарсили, но stderr содержит actionable
+  // строки — эмитим generic {code:"unknown", message: head(stderr)}.
+  // Vite/npm/Node постоянно выводят deprecation banner'ы и подобный
+  // noise в stderr на УСПЕШНОМ билде; их фильтруем (BENIGN_STDERR_LINE_
+  // PATTERNS), чтобы не получить errorsCount=1 при exitCode=0.
+  if (errors.length === 0) {
+    const meaningful = stripBenignStderr(input.stderr ?? "").trim();
+    if (meaningful) {
+      push({
+        code: "unknown",
+        message: meaningful.slice(0, UNKNOWN_HEAD_BYTES),
+        raw: meaningful.slice(0, UNKNOWN_HEAD_BYTES),
+      });
+    }
   }
 
   return errors;

adorable/tests/build-error-parser.test.ts

@@ -151,6 +151,70 @@ dist/index.html  0.45 kB
   });
 });
 
+describe("parseBuildErrors — benign stderr noise on successful builds", () => {
+  // Real captures from a successful `npx vite build` run inside the
+  // build-runner image (Vite v5.4.21 + npm 10). Reproducer: STATIC_MODE
+  // _REMAINING.md §6 — `errorsCount: 1` with exitCode=0 was caused by the
+  // fallback unknown-error branch firing on these benign banners.
+  const VITE_5_DEPRECATION_BANNER =
+    "The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.";
+  const VITE_5_SUCCESS_STDOUT = `vite v5.4.21 building for production...
+transforming...
+✓ 1601 modules transformed.
+rendering chunks...
+computing gzip size...
+dist/index.html                  0.45 kB │ gzip:   0.30 kB
+dist/assets/index-DJKLm0kF.css  12.34 kB │ gzip:   3.21 kB
+dist/assets/index-Bq2J8Pol.js  178.00 kB │ gzip:  56.78 kB
+✓ built in 6.81s`;
+
+  it("returns [] for the Vite 5.4 CJS deprecation banner alone", () => {
+    expect(
+      parseBuildErrors({ stdout: "", stderr: VITE_5_DEPRECATION_BANNER }),
+    ).toEqual([]);
+  });
+
+  it("returns [] for a full successful Vite 5 build (banner on stderr, summary on stdout)", () => {
+    expect(
+      parseBuildErrors({
+        stdout: VITE_5_SUCCESS_STDOUT,
+        stderr: VITE_5_DEPRECATION_BANNER,
+      }),
+    ).toEqual([]);
+  });
+
+  it("returns [] for npm warn/notice/info noise", () => {
+    const stderr = `npm warn deprecated source-map@0.8.0-beta.0
+npm notice updating package-lock.json
+npm info ok`;
+    expect(parseBuildErrors({ stdout: "", stderr })).toEqual([]);
+  });
+
+  it("returns [] for Browserslist 'is outdated' nag", () => {
+    const stderr = `Browserslist: caniuse-lite is outdated. Please run:
+  npx update-browserslist-db@latest
+  Why you should do it regularly: https://github.com/browserslist/update-db#readme`;
+    // The two known nag lines are stripped; the explanatory third line
+    // remains and *would* trigger the fallback. That is acceptable
+    // behavior — it is unusual to see such output without exitCode=0,
+    // and the build queue already gates errorsCount on exitCode.
+    const errs = parseBuildErrors({ stdout: "", stderr });
+    expect(errs.every((e) => !/caniuse-lite/.test(e.message))).toBe(true);
+  });
+
+  it("still emits an unknown error when stderr contains real failure noise", () => {
+    const stderr = `${VITE_5_DEPRECATION_BANNER}
+Internal error: build executor crashed unexpectedly
+exit code 137`;
+    const errs = parseBuildErrors({ stdout: "", stderr });
+    expect(errs).toHaveLength(1);
+    expect(errs[0].code).toBe("unknown");
+    expect(errs[0].message).toContain("Internal error");
+    // The banner was stripped, the actionable line remained.
+    expect(errs[0].message).not.toContain("CJS build");
+  });
+});
+
 describe("parseBuildWarnings", () => {
   it("captures simple WARNING lines", () => {
     const stderr = `

docs/STATIC_MODE_REMAINING.md

@@ -239,7 +239,27 @@ chown -R 1000:1000 "$DEST"
 
 ---
 
-## 🟡 6. Build артефакт парсится как `errorsCount: 1` при успехе
+## ✅ 6. Build артефакт парсится как `errorsCount: 1` при успехе — DONE
+
+Корень: vite v5.x пишет `The CJS build of Vite's Node API is deprecated...`
+в stderr на каждом успешном билде. Fallback в `parseBuildErrors`
+(`stderr.trim() ≠ "" → emit unknown`) ловил это как ошибку.
+
+Реализовано:
+- `lib/preview/build-error-parser.ts` — добавлен набор узких regex'ов
+  `BENIGN_STDERR_LINE_PATTERNS` для известного шума (Vite CJS deprecation
+  banner, `npm warn/notice/info`, Browserslist outdated nag).
+- Helper `stripBenignStderr(stderr)` экспортирован.
+- Fallback теперь работает поверх `stripBenignStderr(input.stderr).trim()`,
+  а не на raw stderr.
+- 5 новых тестов в `build-error-parser.test.ts` фиксируют:
+  (a) banner-only stderr → 0 errors,
+  (b) full Vite v5.4.21 success run → 0 errors,
+  (c) npm warn/notice/info → 0 errors,
+  (d) Browserslist nag → строка не появляется в `errors[].message`,
+  (e) реальная ошибка над banner'ом всё ещё ловится.
+
+
 
 ### Симптом
 ```json