compiler now uses the markup diag position where possible.

While this is mostly working it isn't really the best and will have to rework how markup diagnostics is done if we want better diagnostics.
Something for the future.

Author: McJones

CHANGELOG.md

@@ -46,6 +46,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Comments in headers are now correctly being determined
   - in predefined headers like `title` this fixes a parsing error
   - in free-form headers this fixes comments being part of the value of the header
+- fixed a crash in some weeeeeeird markup structures
 
 ### Removed
 

YarnSpinner.Compiler/Compiler.cs

@@ -254,15 +254,27 @@ public static CompilationResult Compile(CompilationJob compilationJob)
                 var result = lineParser.ParseStringAndIncludeMarkupDiagnostics(line.Value.text, System.Globalization.CultureInfo.InvariantCulture.TwoLetterISOLanguageName);
                 foreach (var diag in result.diagnostics)
                 {
-                    // TODO: Markup diagnostic column information is currently
-                    // not set; default the range to the entirety of the line
-                    // for now
-                    var range = new Range(
-                        line.Value.lineNumber - 1,
-                        0,
-                        line.Value.lineNumber - 1,
-                        line.Value.text.Length
-                    );
+                    // TODO: change how markup presents it's diagnostics so we can get more useful diagnostics
+                    // if the position is -1 we want the whole line, otherwise we want to just say where the problem began
+                    Range range;
+                    if (diag.Column == -1)
+                    {
+                        range = new Range(
+                            line.Value.lineNumber - 1,
+                            0,
+                            line.Value.lineNumber - 1,
+                            line.Value.text.Length
+                        );
+                    }
+                    else
+                    {
+                        range = new Range(
+                            line.Value.lineNumber - 1,
+                            diag.Column,
+                            line.Value.lineNumber - 1,
+                            diag.Column
+                        );
+                    }
                     diagnostics.Add(DiagnosticDescriptor.MarkupFailedToParse.Create(line.Value.fileName, range, diag.Message));
                 }
             }