Skip to content

Fix merged lane-launch ownership, privacy, and --attach regressions #287

Description

@jaeyunha

Context\n\nPR #286 merged to dev as 3a4285c0ef0f42d98269aeb6bc61bd4fe9f11c6a while three current-head review findings remained unresolved. Parent spec #285 was then closed. These are concrete follow-up regressions and block the live Mac-mini rollout/release gate.\n\n## Defects\n\n1. P1: command submission can target an unrelated existing tmux session\n - src/tmux_wrapper.rs currently accepts DetachedSessionOutcome::PossiblyExecuted for command lanes and proceeds to identity-marker writes and send-keys.\n - Reproduction boundary: reserve the requested session name with an unrelated tmux session so tmux new-session -s <name> fails. The lane launch must stop without writing markers or submitting the command.\n - Original finding: https://github.com/Yeachan-Heo/clawhip/pull/286#discussion_r3562892911\n\n2. P2: raw Discord thread ID leaks from lane launch JSON\n - emit_lane_result inserts args.thread as thread_id for tmux new --thread ... --json.\n - Public/status output should use the same redacted or fingerprinted target representation as other lane projections.\n - Original finding: https://github.com/Yeachan-Heo/clawhip/pull/286#discussion_r3562892913\n\n3. P2: lane-aware --attach is silently ignored\n - The lane-aware early return routes through launch_lane_session, which never invokes attach_session.\n - clawhip tmux new --thread ... --attach creates/launches the lane and exits instead of attaching.\n - Original finding: https://github.com/Yeachan-Heo/clawhip/pull/286#discussion_r3562908691\n\n## Done when\n\n- Add focused regression tests for all three paths.\n- A failed/non-owned command-lane creation has no marker or command-submission effect on the pre-existing session.\n- JSON launch output does not expose the raw private thread target.\n- --attach behavior remains compatible for lane-aware launches.\n- cargo fmt --check, cargo clippy -- -D warnings, and cargo test pass.\n- Complete a live Discord/Mac-mini canary before patch release.\n\nThe installed Mac-mini canary remains on the narrower fork patch until these regressions are resolved.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions