Skip to content

Conversation

@FAMarfuaty
Copy link
Contributor

@FAMarfuaty FAMarfuaty commented Dec 8, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the Yoast AI consent modal would incorrectly pop up when interacting with unrelated buttons or fields on Profile setting page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install and activate Yoast SEO
  • Make sure the AI Feature is enabled in the plugin setting
  • Go to profile setting
  • Interact with a field that is not Revoke consent or Grant consent button. For example, fill in the pronoun field.
  • Hit enter
  • Confirm that the AI consent modal is not displayed
  • Save the changes
  • Confirm the changes persist
  • Smoke test the Revoke consent and Grant consent buttons and confirm that they still work as expected.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22756

@FAMarfuaty FAMarfuaty added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Dec 8, 2025
@FAMarfuaty FAMarfuaty marked this pull request as ready for review December 8, 2025 14:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18b4323c37d47e25bce704c14a6703b460374720

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 53.039%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-consent/initialize.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/ai-consent/initialize.js 1 0.0%
Totals Coverage Status
Change from base Build 3953764123d71d76729b2ec7e7f5816cbab76e29: -0.006%
Covered Lines: 32426
Relevant Lines: 61471

💛 - Coveralls

Copy link
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the 26.7 milestone Dec 8, 2025
@vraja-pro vraja-pro merged commit 23b21a4 into trunk Dec 8, 2025
22 of 23 checks passed
@vraja-pro vraja-pro deleted the 22756-ai-consent-popup-wrongly-appears-in-the-wordpress-profile-page branch December 8, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AI consent popup wrongly appears in the WordPress Profile page

3 participants