refactor: consolidate pnpm configuration into pnpm-workspace.yaml and clean up .npmrc and package.json5

Author: antitoxic

.npmrc

@@ -1,47 +1,8 @@
 ;;; Your private registry
 ;;; registry = XXX
 
-;;; Node.js version that will be automatically used
-use-node-version = 22.6.0
-
 ;;; During development of this package, only allow node & npm versions stated in package.json::engines
 engine-strict = true
 
-;;; Prevent installing dependencies for ALL packages every time `pnpm install` is run
-recursive-install = false
-
-;;; Do not bunch together peer dependencies in the root node_modules
-resolve-peers-from-workspace-root = false
-hoist = false
-
-;;; Do not auto-install peer deps
-auto-install-peers = false
-
-;; needed due to a bug in `recursive-install`
-;; ref 1: https://github.com/pnpm/pnpm/issues/6300
-;; ref 2: https://github.com/pnpm/pnpm/issues/5508
-dedupe-peer-dependents = false
-
 ;;; Disable version update reminders, we don't want developers to have different versions
-update-notifier = false
-
-;;; Let's be explicit about the shell that executes the "scripts" in package.json
-script-shell = bash
-
-;;; Don't allow circular dependencies between projects in this repo
-disallow-workspace-cycles = true
-
-;;; When available, default to using local package when running `pnpm install <package name>`
-link-workspace-packages = true
-
-;;; If node_modules is outdated, fail the running command
-verify-deps-before-run = error
-
-;;; Fail installation if a dependency has postinstall that is neither approved or ignored
-strict-dep-builds = true
-
-;;; Don't ignore patch failures during install
-ignore-patch-failures = false
-
-;;; Minimum age in minutes for any package that gets installed
-minimum-release-age = 1440
+update-notifier = false

package.json5

@@ -84,6 +84,9 @@
     'shared:repo:fix:lint:package.json:dependencies': 'pnpm --filter=@repo/syncpack-base-isolated run fix:syncpack',
     // different naming from the other fixing commands so that it's not executed when you do pnpm --workspace-root run '/^shared:fix:.+/'
     'shared:staged:fix:common': "PACKAGE_DIR=$INIT_CWD pnpm --filter=@repo/lint-staged-base-isolated run staged:fix:lint --diff='--cached'",
+    /**
+     * SHORTCUTS FOR COMMANDS THAT DON'T APPLY TO SPECIFIC PACKAGE BUT TO ALL OF THEM
+     */
     // checks if dependencies which are not explicitly allowed to have different version are the same across all `packages.json`
     'repo:lint:package.json:dependencies': 'pnpm --filter=@repo/syncpack-base-isolated run syncpack:lint',
     // list all packages in the repo
@@ -129,197 +132,7 @@
    * This is achieved with a little bit of customization in .pnpmfile.cjs
    */
   codeEditorIntegrationDependencies: {
-    eslint: '9.30.1', /**
-     * SHORTCUTS FOR COMMANDS THAT DON'T APPLY TO SPECIFIC PACKAGE BUT TO ALL OF THEM
-     */ /* [comment possibly relocated by pnpm] */
+    eslint: '9.30.1', 
     prettier: '3.4.2',
   },
-  /**
-   * Fixes and overrides of dependencies across packages in the repo
-   */
-  pnpm: {
-    /**
-     * Override the older versions of those nested dependencies so we get some bug fixes
-     */
-    overrides: {
-      cosmiconfig: '^9',
-      '@jest/globals@29>@jest/environment': '-',
-      '@jest/globals@29>@jest/expect': '-',
-      '@jest/globals@29>@jest/types': '-',
-    },
-    packageExtensions: {
-      /**
-       * We patch eslint-plugin-json-schema-validator to enable custom errors
-       * which means we need the ajv packages as peer deps
-       */
-      'eslint-plugin-json-schema-validator': {
-        peerDependencies: {
-          ajv: '*',
-          'ajv-errors': '*',
-        },
-      },
-      /**
-       * Fix problems in third party package definitions
-       */
-      '@reactflow/core': { /**
-     * SHORTCUTS FOR RELEASING PACKAGES
-     */ /* [comment possibly relocated by pnpm] */
-        peerDependencies: {
-          '@types/react': '*',
-        },
-      },
-      'react-toastify': {
-        peerDependencies: {
-          'react-dom': '*',
-        },
-      },
-      // We want webpack-cli always available to webpack when installed as peer dependency
-      webpack: { /**
-     * MISC USEFUL SHORTCUTS
-     */ /* [comment possibly relocated by pnpm] */
-        peerDependencies: {
-          'webpack-cli': '*',
-        },
-      },
-      // hygen have not defined any ts loaders as peers, so we need to fix that
-      hygen: {
-        peerDependencies: {
-          tsx: '*',
-        },
-      },
-      '@angular-devkit/build-angular': {
-        peerDependencies: {
-          'ng-packagr': '*',
-        },
-      },
-      '@angular-builders/custom-webpack': {
-        dependencies: {
-          rxjs: '*',
-        },
-      },
-      '@angular-architects/module-federation': {
-        peerDependencies: {
-          tslib: '*',
-          webpack: '*',
-        },
-        dependencies: {
-          json5: '*',
-        },
-      },
-      'jest-runner': {
-        peerDependencies: {
-          tslib: '*',
-        },
-      },
-      'jest-environment-jsdom': {
-        peerDependencies: {
-          tslib: '*',
-        },
-      },
-      /**
-     * SHORTCUTS FOR CODE-EDITOR INTEGRATIONS
-     */ /* [comment possibly relocated by pnpm] */ /* [comment possibly relocated by pnpm] */ /* [comment possibly relocated by pnpm] */
-      'jest-preset-angular': {
-        dependencies: {
-          'zone.js': '*',
-        },
-      },
-      'jest-circus': {
-        peerDependencies: {
-          tslib: '*',
-        },
-      },
-      'jest-config': {
-        dependencies: {
-          'ts-node': '*',
-        },
-      },
-      '@testing-library/jest-dom': {
-        dependencies: {
-          '@types/aria-query': '*',
-        },
-        peerDependencies: {
-          '@types/react': '*',
-        },
-      },
-      '@testing-library/react': {
-        peerDependencies: {
-          '@types/react-dom': '*',
-        },
-      },
-      '@jest/globals@29': {
-        peerDependencies: {
-          '@jest/environment': '^29.7.0',
-          '@jest/expect': '^29.7.0',
-          '@jest/types': '^29.6.3',
-        },
-      },
-      'react-i18next': {
-        peerDependencies: {
-          '@types/react': '*',
-        },
-      },
-      tslib: {
-        dependencies: {
-          'ts-node': '*',
-        },
-      },
-      '@auth0/auth0-angular': {
-        dependencies: {
-          rxjs: '*',
-        },
-      },
-      '@angular-builders/common': {
-        peerDependencies: {
-          'mini-css-extract-plugin': '*',
-        },
-      },
-      '@pnpm/filter-workspace-packages': {
-        peerDependencies: {
-          '@pnpm/types': '*',
-        },
-      },
-      zx: {
-        peerDependencies: {
-          '@types/fs-extra': '*',
-        },
-      },
-      '@eslint/eslintrc': {
-        peerDependencies: {
-          eslint: '*',
-        },
-      },
-    },
-    patchedDependencies: {
-      /**
-       * We patch hygen due to:
-       * 1. a bug in color highlighting: https://github.com/jondot/hygen/issues/265
-       * 2. using `tsx` instead of `ts-node` since `ts-node` is stale and does not support extending multiple tsconfigs
-       */
-      '[email protected]': 'infra/devx-and-repo/generators/patches/[email protected]',
-      /**
-       * With this patch, we enable custom error messages via ajv-error
-       */
-      'eslint-plugin-json-schema-validator': 'infra/code-checks/eslint-base-isolated/patches/eslint-plugin-json-schema-validator.patch',
-      /**
-       * With this patch, we make sure `lint-staged` recognizes its own `lint-staged` node_modules/.bin
-       * files
-       */
-      'lint-staged': 'infra/code-checks/lint-staged-base-isolated/patches/lint-staged.patch',
-      /**
-       * With this patch, we make sure `depcheck` recognizes the `package` option even when run as CLI
-       */
-      depcheck: 'infra/code-checks/depcheck-base-isolated/patches/depcheck.patch',
-      /**
-       * Allow `filterPackages` to accept a new option called `createPkgGraph` to customize the graph
-       */
-      '@pnpm/filter-workspace-packages': 'infra/devx-and-repo/repo-shell-scripts/patches/@pnpm__filter-workspace-packages.patch',
-    },
-    onlyBuiltDependencies: [
-      '@swc/core',
-      'core-js',
-      'cypress',
-      'esbuild',
-    ],
-  },
 }