add net47 to unit test

Author: DennisDyallo

.github/workflows/test-windows.yml

@@ -24,12 +24,12 @@ jobs:
       - name: Add local NuGet repository
         run: dotnet nuget add source --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text --name github "https://nuget.pkg.github.com/Yubico/index.json"
 
-
       - name: Test Yubico.Core (NET47)
         run: dotnet test Yubico.Core/tests/unit/Yubico.Core.UnitTests.csproj -f net47 --logger trx --settings coverlet.runsettings.xml --collect:"XPlat Code Coverage"
 
       - name: Test Yubico.YubiKey
         run: dotnet test Yubico.YubiKey/tests/unit/Yubico.YubiKey.UnitTests.csproj --logger trx --settings coverlet.runsettings.xml --collect:"XPlat Code Coverage"
+      
       - name: Test Yubico.Core Integration tests (NET6)
         run: dotnet test Yubico.Core/tests/integration/Yubico.Core.IntegrationTests.csproj -f net6.0 --logger trx --settings coverlet.runsettings.xml --collect:"XPlat Code Coverage"
 

Yubico.Core/tests/unit/Yubico.Core.UnitTests.csproj

@@ -18,7 +18,7 @@ limitations under the License. -->
     <AssemblyName>Yubico.Core.UnitTests</AssemblyName>
     <RootNamespace></RootNamespace>
 
-    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net8.0;net47</TargetFrameworks>
     <AnalysisMode>Minimum</AnalysisMode>
 
     <!-- StrongName signing -->

Yubico.Core/tests/unit/Yubico/Core/Cryptography/AesGcmPrimitivesOpenSslTests.cs

@@ -55,6 +55,7 @@ public void Encrypt_Decrypt_Succeeds()
             Assert.True(isValid);
         }
 
+#if !NET47
         [SkippableFact(typeof(System.PlatformNotSupportedException))]
         public void Encrypt_Decrypt_Succeeds_RandomValues_Succeed()
         {
@@ -95,6 +96,9 @@ public void Encrypt_Decrypt_Succeeds_RandomValues_Succeed()
             isValid = plaintext.AsSpan().SequenceEqual(decryptedData.AsSpan());
             Assert.True(isValid);
         }
+#else
+
+#endif
 
         private static byte[] GetKeyData(
             RandomNumberGenerator? random)

Yubico.Core/tests/unit/Yubico/Core/Devices/Hid/HidTranslatorTests.cs

@@ -166,10 +166,18 @@ public static IEnumerable<object[]> GetTestData()
             // Originally, I hard-coded these, but I decided that it should do
             // this dynamically so that newly added keyboard layouts aren't left
             // out of these tests.
+            
+#if NET6_0_OR_GREATER
             foreach (KeyboardLayout layout in Enum.GetValues<KeyboardLayout>())
             {
                 yield return new object[] { layout, GetDataForKeyboard(layout) };
             }
+#else
+            foreach (KeyboardLayout layout in Enum.GetValues(typeof(KeyboardLayout)))
+            {
+                yield return new object[] { layout, GetDataForKeyboard(layout) };
+            }
+#endif
         }
 
         // This method gets an array of tuples with the character and HID usage

Yubico.Core/tests/unit/Yubico/Core/Iso7816/CommandApduTests.cs

@@ -35,7 +35,12 @@ public class CommandApduTests
         private static byte[] GenerateRandBytes(int length)
         {
             byte[] randBytes = new byte[length];
+#if NET6_0_OR_GREATER
             System.Security.Cryptography.RandomNumberGenerator.Fill(randBytes);
+#else
+            System.Security.Cryptography.RandomNumberGenerator.Create().GetBytes(randBytes);
+#endif
+
             return randBytes;
         }
 

Yubico.Core/tests/unit/Yubico/Core/Tlv/TlvWriterTests.cs

@@ -478,7 +478,7 @@ public void EncodeTag_Has_Correct_LengthAndOffset()
                 var reader = new TlvReader(encoding);
                 Assert.Equal(bytesSize, reader.PeekLength());
 
-                var bytesAsHex = encoding[..9].Select(b => b.ToString("X2"));
+                var bytesAsHex = encoding.AsSpan()[..9].ToArray().Select(b => b.ToString("X2"));
                 PrettyPrint(bytesSize, bytesAsHex);
 
                 // Increase for next round