Merge pull request #230 from Yubico/dennisdyallo/tests

fix,tests: Fixed bug where attest cert could not be RSA3072 or RSA4096, removed obsolete tests and consolidated Piv tests

Author: DennisDyallo

Yubico.YubiKey/examples/PivSampleCode/CertificateOperations/SampleCertificateOperations.cs

@@ -497,7 +497,9 @@ public static AsymmetricAlgorithm GetPublicKeyFromCertificate(X509Certificate2 c
 
             if (string.Equals(certificate.PublicKey.Oid.FriendlyName, "ECC", StringComparison.Ordinal))
             {
+#pragma warning disable CS0618 // Type or member is obsolete
                 var pivPub = new PivEccPublicKey(certificate.PublicKey.EncodedKeyValue.RawData);
+#pragma warning restore CS0618 // Type or member is obsolete
                 return KeyConverter.GetDotNetFromPivPublicKey(pivPub);
             }
 

Yubico.YubiKey/examples/PivSampleCode/Converters/KeyConverter.Asymmetric.cs

@@ -65,7 +65,9 @@ public static PivPublicKey GetPivPublicKeyFromDotNet(AsymmetricAlgorithm dotNetO
                 offset += keySize + (keySize - eccParams.Q.Y.Length);
                 Array.Copy(eccParams.Q.Y, 0, point, offset, eccParams.Q.Y.Length);
 
+#pragma warning disable CS0618 // Type or member is obsolete
                 var eccPubKey = new PivEccPublicKey(point);
+#pragma warning restore CS0618 // Type or member is obsolete
                 return (PivPublicKey)eccPubKey;
             }