feat: Implement reading of VersionQualifier into YubikeyDeviceInfo

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/VersionQualifier.cs

@@ -62,14 +62,10 @@ internal class VersionQualifier
     /// <exception cref="ArgumentNullException"></exception>
     public VersionQualifier(FirmwareVersion firmwareVersion, VersionQualifierType type, long iteration)
     {
-        if (iteration < 0)
+        if (iteration < 0 || iteration > uint.MaxValue)
         {
-            throw new ArgumentOutOfRangeException(nameof(iteration), "Iteration must be a non-negative value.");
-        }
-
-        if (iteration > uint.MaxValue)
-        {
-            throw new ArgumentOutOfRangeException(nameof(iteration), "Iteration must be less than or equal to int.MaxValue.");
+            throw new ArgumentOutOfRangeException(nameof(iteration),
+                $"Iteration must be between 0 and {uint.MaxValue}.");
         }
 
         FirmwareVersion = firmwareVersion ?? throw new ArgumentNullException(nameof(firmwareVersion));

Yubico.YubiKey/tests/unit/Yubico/YubiKey/YubikeyDeviceInfoTests.cs

@@ -280,7 +280,6 @@ private static YubiKeyDeviceInfo DeviceInfoFor(int tag, byte[] deviceInfoData, F
                 SetVersionTag(tag, version, tlvs);
             }
 
-            SetVersionQualifierTag(versionQualifier, tlvs);
 
             return YubiKeyDeviceInfo.CreateFromResponseData(tlvs); //We're testing this method
         }
@@ -298,25 +297,6 @@ private static void SetVersionTag(int tag, FirmwareVersion? version, Dictionary<
             }
         }
 
-        private static void SetVersionQualifierTag(VersionQualifier? versionQualifier, Dictionary<int, ReadOnlyMemory<byte>> tlvs)
-        {
-            if (versionQualifier is null)
-            {
-                return;
-            }
-
-            var tlvVq = TlvObjects.EncodeMany(
-                new TlvObject(0x01, VersionToBytes(versionQualifier.FirmwareVersion)),
-                new TlvObject(0x02, [(byte)versionQualifier.Type]),
-                new TlvObject(0x03, [0, 0, 0, (byte)versionQualifier.Iteration]));
-
-            var tlvVqLength = tlvVq.Length;
-            Debug.WriteLine($"VersionQualifier TLV length: {tlvVqLength}");
-
-            const byte versionQualifierTag = 0x019;
-            tlvs.Add(versionQualifierTag, tlvVq);
-        }
-
         private static byte[] VersionToBytes(FirmwareVersion version) => [version.Major, version.Minor, version.Patch];
 
         private static byte[] FromHex(string? hex) => hex != null ? Base16.DecodeText(hex) : Array.Empty<byte>();