Skip to content

Commit 8aeb17d

Browse files
fix: resolve all remaining errcheck violations for complete CI compliance
- Fixed unchecked conn.Close() in pool shutdown and connection cleanup - Fixed unchecked conn.Close() in worker socket readiness check - Added errcheck to local linter configuration for consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent f0b9b3b commit 8aeb17d

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.golangci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ linters:
99
- goimports
1010
- revive
1111
- misspell
12+
- errcheck
1213

1314
issues:
1415
exclude-use-default: false

pkg/pyproc/pool.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ func (p *Pool) Shutdown(_ context.Context) error {
256256
for _, pw := range p.workers {
257257
close(pw.connPool)
258258
for conn := range pw.connPool {
259-
conn.Close()
259+
_ = conn.Close()
260260
}
261261
}
262262

@@ -299,7 +299,7 @@ func (w *Worker) IsHealthy(ctx context.Context) bool {
299299
if err != nil {
300300
return false
301301
}
302-
conn.Close()
302+
_ = conn.Close()
303303
return true
304304
}
305305

pkg/pyproc/worker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func (w *Worker) Start(ctx context.Context) error {
119119
// Try to connect to the socket
120120
conn, err := net.Dial("unix", w.cfg.SocketPath)
121121
if err == nil {
122-
conn.Close()
122+
_ = conn.Close()
123123
socketReady <- nil
124124
return
125125
}

0 commit comments

Comments
 (0)